chore(core): fix JsonObject type doesn't allow array of JsonObject as field #13669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
a team
as code owners
HuiSF
force-pushed
the
hui/fix/core/json-array-type
branch
from
6d89db1 to
d2d939d
Compare
HuiSF
force-pushed
the
hui/fix/core/json-array-type
branch
from
6f2072e to
bdff20c
Compare
ashika112
previously approved these changes
Aug 1, 2024
haverchuck
previously approved these changes
Aug 1, 2024
ashika112
previously approved these changes
Aug 1, 2024
cshfang
previously approved these changes
Aug 1, 2024
ashika112
approved these changes
Aug 2, 2024
cshfang
approved these changes
Aug 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
#13667
Description of how you validated changes
Perform type casting in a unit test to verify array of object is allowed. The unit test will fail when casted type is non-compatible.
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.