fix(api-rest): infinite retry when clock skew go back and forth #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinleigh90
previously approved these changes
Nov 1, 2023
cshfang
previously approved these changes
Nov 1, 2023
Merged
4 tasks
AllanZhengYP
dismissed stale reviews from cshfang and erinleigh90
via
b3d6836
cshfang
previously approved these changes
Nov 6, 2023
erinleigh90
previously approved these changes
Nov 6, 2023
AllanZhengYP
dismissed stale reviews from erinleigh90 and cshfang
via
38904db
elorzafe
approved these changes
Nov 6, 2023
jimblanc
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change makes sure when updating the clock skew offset, always compare to raw client clock instead the one adjusted by clock skew offset.
Issue #, if available
For more details on why this happens: #12450 (comment)
Description of how you validated changes
Unit test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.