fix(@aws-amplify/datastore): extra fields in selective sync selection set on API's from older CLI #10929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svidgen
force-pushed
the
fix-selective-sync-selection-set
branch
from
c1b3a7f
to
4a7bdd5
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #10929 +/- ##
==========================================
- Coverage 81.48% 81.48% -0.01%
==========================================
Files 198 198
Lines 19692 19691 -1
Branches 4249 4248 -1
==========================================
- Hits 16047 16046 -1
Misses 3354 3354
Partials 291 291
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Addressed in #10949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes an issue where the selection for selective sync expressions was incorrect for apps build with some older versions of the CLI. Related-model key fields were included in the selection set, but were not recognized by cloud storage. This issue was introduced in with the nested predicates feature, which added the implicitly created FK fields to the table metadata
fieldslist so they could be seen by the predicate builder.This PR removes the logic that augments the
fieldslist and add a newallFieldslist. All pre-existing (prior to lazy loading/nested predicates) will revert to use only the explicitly definedfieldslist. The predicates builder will useallFields.Issue #, if available
#10785
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.