-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Lints #918
Merged
dnys1
merged 38 commits into
aws-amplify:release-candidate
from
dnys1:configuration-error
Oct 28, 2021
Merged
chore: Lints #918
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
d47c95f
Reorg + integ tests
053428e
Clean up
6a652ee
Update tests; attempt Android
53c0378
Throw if Android
847b0f4
Lint amplify_flutter and amplify_core
536f232
Fix
eac58a8
Re-enable CI/CD lints
49d6109
Fix amplify_flutter tests
3e0aa13
Run Android lints
899c8e6
Fix formatting
a7c50f4
Keep trying Android reset
06246b1
Create amplify_test_flutter package
ccff951
Fix API auth for REST (#925)
dnys1 6749fbb
feat(datastore): Add ModelField ReadOnly support (#599)
fjnoyp d807487
chore: 0.2.5 release (#975)
207a739
feat(datastore): add observeQuery API (#892)
128f035
Revert "feat(datastore): Add ModelField ReadOnly support (#599)" (#994)
17454f4
chore: 0.2.6 release (#993)
8846418
Fix imports
dac3a5c
Fix linting
a9b77d7
Update dependencies
ddc7a21
Add missing build tools
14409a9
Update pubspecs
140e1e3
Revert Android changes
05e1629
Use local dependencies
295ecf4
Update license and readme
57d3493
Trigger CI
39ae1eb
Fix imports
38ee1c8
Fix lints
121b58e
Revert amplify_flutter change
62a3860
Remove unnecessary lint disable
fb983dc
Revert DataStore model changes; fix yellow
e4cd233
Revert test pkg & integ tests
87f0748
Fix amplify_flutter example
4c2975b
Fix amplify_flutter example
9a1bb39
Fix amplify_flutter example
b18f154
Remove uuid from API plugin deps
cc49f79
Misc corrections
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
$swift_version = "5.0" | ||
|
||
# Include common tooling | ||
def include_build_tools! | ||
# Pin to 0.44.17 until we resolve closing braces | ||
pod 'SwiftFormat/CLI', '0.44.17' | ||
pod 'SwiftLint' | ||
end | ||
|
||
$lint_script = <<-EOF | ||
CONFIG_FILE="${SRCROOT}/../../../../../.swiftformat" | ||
if [[ -e "${CONFIG_FILE}" ]]; then | ||
"${PODS_ROOT}/SwiftFormat/CommandLineTool/swiftformat" --config "${CONFIG_FILE}" --swiftversion "#{$swift_version}" "${SRCROOT}/../.symlinks/plugins/${PRODUCT_NAME}/ios" | ||
fi | ||
EOF | ||
|
||
$format_script = <<-EOF | ||
CONFIG_FILE="${SRCROOT}/../../../../../.swiftlint.yml" | ||
if [[ -e "${CONFIG_FILE}" ]]; then | ||
"${PODS_ROOT}/SwiftLint/swiftlint" --config "${CONFIG_FILE}" --path "${SRCROOT}/../.symlinks/plugins/${PRODUCT_NAME}/ios" | ||
fi | ||
EOF | ||
|
||
$default_script_phases = [ | ||
# Format build phase | ||
{ | ||
:name => 'SwiftFormat', | ||
:script => $lint_script, | ||
:execution_position => :before_compile | ||
}, | ||
|
||
# Lint build phase | ||
{ | ||
:name => 'SwiftLint', | ||
:script => $format_script, | ||
:execution_position => :before_compile | ||
}, | ||
] | ||
|
||
def get_plugin_dir(plugin_name) | ||
return File.join('.symlinks', 'plugins', plugin_name, 'ios') | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for copying + reading copies rather than reading centralized version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much of a reason in the examples, since they will only ever be run from the repo. But in general, it must be copied to each package because they are shipped independently in pub. This issue is why we had to do the 0.2.4 release 😅 because it was throwing errors that the file wasn't there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks for explanation