Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): update uploadData API to accept optional storage bucket param #5540

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Oct 9, 2024

Issue #, if available:

Description of changes:

  • update uploadData API to accept optional storage bucket parameter
  • update transfer database to add bucket name and region. this is required by abortIncompleteMultipartUploads for creating approprate s3 client.
  • update S3ClientInfo to add bucket name and region so that we can get all the s3 info by calling getS3ClientInfo and eliminate multiple calls to resolve bucket info
  • add unit tests for storage bucket resolve bucket info

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner October 9, 2024 21:12
@NikaHsn NikaHsn merged commit 3eafd51 into multi-bucket Oct 14, 2024
154 of 155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants