chore(actions): xcodes ios 18 fix #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
previously approved these changes
Jul 11, 2024
| @@ -3,7 +3,7 @@ description: Launches an iOS simulator and caches it for further action runs | |||
| inputs: | |||
| ios-version: | |||
| description: The iOS version | |||
| default: "latest" | |||
There was a problem hiding this comment.
do we have to change this back to latest once ios 18 releases? if so, should we put a todo in there?
There was a problem hiding this comment.
Not necessarily. It's likely that we will have to completely revise our entire process in order to download iOS18 runtimes. I can add a todo to reflect that.
khatruong2009
approved these changes
Jul 12, 2024
tyllark
approved these changes
Jul 12, 2024
Equartey
added a commit
that referenced
this pull request
Jul 17, 2024
Equartey
added a commit
that referenced
this pull request
Jul 17, 2024
Equartey
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ios-version: latesttoios-version: "17.5"when trying to download the iOS simulator runtime. This is due the breaking change Apple introduced with iOS 18. The cli tool we usexcodesdoes not support iOS 18. This can revisited when the community finds a reliable way to download iOS 18 runtimes.pnpmsetup action version to 4.0.0pnpmversion to 9.5By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.