fix(amplify_datastore): avoid tearing down iOS subscription after clear() #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
approved these changes
Feb 20, 2021
packages/amplify_datastore/ios/Classes/SwiftAmplifyDataStorePlugin.swift
Outdated
Show resolved
Hide resolved
…ugin.swift Co-authored-by: Michael Law <[email protected]>
|
Pulled this branch locally and it fixed my test app linked to in #395 so 👍🏻 👍🏻 from me. |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 67.94% 67.95% +0.01%
==========================================
Files 240 240
Lines 7471 7478 +7
Branches 323 323
==========================================
+ Hits 5076 5082 +6
- Misses 2277 2278 +1
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
haverchuck
reviewed
Feb 25, 2021
| @@ -280,6 +284,10 @@ public class SwiftAmplifyDataStorePlugin: NSObject, FlutterPlugin { | |||
| flutterResult: flutterResult) | |||
| case .success(): | |||
| print("Successfully cleared the store") | |||
| // iOS tears down the publisher after clear. Let's setup again. | |||
| // See https://github.com/aws-amplify/amplify-flutter/issues/395 | |||
There was a problem hiding this comment.
I like citing the GH issue in this way.
haverchuck
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #395
Description of changes: fix(amplify_datastore): avoid tearing down iOS subscription after clear()
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.