Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(version): Bump version #3524

Merged
merged 24 commits into from
Aug 7, 2023
Merged

chore(version): Bump version #3524

merged 24 commits into from
Aug 7, 2023

Conversation

ragingsquirrel3
Copy link
Contributor

Version bump for 1.3.1 (not all packages affected because no features).

Fixes

  • fix(auth): Android Hosted UI flakiness
  • fix(auth): Remove nonce usage (#3321)
  • fix(datastore): hot restart (#3497)
  • fix(datastore): make event history list thread safe (#3509)
  • fix(push): Incorrect handling of simple alert (#3502)
  • perf(auth): Fetch auth session (#3510)
    Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Equartey and others added 23 commits August 7, 2023 09:43
@Equartey
chore(datastore): removed analysis options (#3455)
ef740f5
@dnys1
docs(repo): Add semantic versioning callout (#3495)
314f375 
Adds callout for semantic versioning around sealed classes and enums.
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
635ab80 
…in /packages/analytics/amplify_analytics_pinpoint/android (#3490)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
69def7d 
…in /packages/amplify_native_legacy_wrapper/android (#3489)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
95ef5bf 
…in /packages/common/amplify_db_common/android (#3483)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
674b503 
…in /packages/amplify_datastore/android (#3488)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
a2e746c 
…in /packages/notifications/push/amplify_push_notifications/android (#3484)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
ea89ea4 
…in /packages/auth/amplify_auth_cognito/android (#3487)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump com.android.tools.build:gradle from 8.0.2 to 8.1.0 …
79257ac 
…in /packages/secure_storage/amplify_secure_storage/android (#3485)

chore(deps): bump com.android.tools.build:gradle

Bumps com.android.tools.build:gradle from 8.0.2 to 8.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dnys1
fix(auth): Remove nonce usage (#3321)
cbf5f74 
fix(auth): Remove nonce check
chore(auth): Fix Android deprecations
8049254 
Uses newer APIs on 33+ and suppresses deprecations on older APIs.
fix(auth): Android Hosted UI flakiness
8b61b18 
The current implementation relies on a timer to trigger the cancellation of any pending sign-in/out operations. This is because of limitations with the Custom Tab intent, but leads to inherent flakiness.

Thinking about it again, we can leverage the same intent mechanism to ensure that in either the success or cancellation case, the right choice is made on how to proceed.
@dependabot
chore(deps): Bump Amplify Android to 2.11.1 (#3486)
7be1da2 
* chore(deps): bump com.amplifyframework:aws-push-notifications-pinpoint-common

Bumps [com.amplifyframework:aws-push-notifications-pinpoint-common](https://github.com/aws-amplify/amplify-android) from 2.10.0 to 2.11.1.
- [Release notes](https://github.com/aws-amplify/amplify-android/releases)
- [Changelog](https://github.com/aws-amplify/amplify-android/blob/main/CHANGELOG.md)
- [Commits](aws-amplify/amplify-android@release_v2.10.0...release_v2.11.1)

---
updated-dependencies:
- dependency-name: com.amplifyframework:aws-push-notifications-pinpoint-common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): Bump Amplify Android to 2.11.1

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dillon Nys <[email protected]>
@dnys1
fix(push): Incorrect handling of simple alert (#3502)
fb091c3 
Fixes #3435.

Simple alerts on iOS take the shape (see [docs](https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html)):

```json
{
  "aps": {
    "alert": "Message"
   }
}
```

This case was not being handled in the deserializer (only the case where `alert` was a Map).
@dependabot @Jordan-Nelson
chore(deps): bump analyzer from 5.13.0 to 6.0.0 in /packages/worker_b…
2bd0bb4 
…ee/worker_bee_builder (#3451)

* chore(deps): bump analyzer in /packages/worker_bee/worker_bee_builder

Bumps [analyzer](https://github.com/dart-lang/sdk/tree/main/pkg) from 5.13.0 to 6.0.0.
- [Changelog](https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/sdk/commits/HEAD/pkg)

---
updated-dependencies:
- dependency-name: analyzer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: Update analyzer lower bound

* chore: update version constraint

* chore: update version range

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Nelson <[email protected]>
@dependabot
chore(deps): Bump aws-cdk-lib from 2.77.0 to 2.80.0 in /infra (#3503)
fe43631 
Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.77.0 to 2.80.0.
- [Release notes](https://github.com/aws/aws-cdk/releases)
- [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.md)
- [Commits](https://github.com/aws/aws-cdk/commits/v2.80.0/packages/aws-cdk-lib)

---
updated-dependencies:
- dependency-name: aws-cdk-lib
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): Bump semver from 6.3.0 to 6.3.1 in /infra (#3505)
2afbc0e 
Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
- [Commits](npm/node-semver@v6.3.0...v6.3.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Jordan-Nelson
chore: update client-cognito-identity-provider (#3507)
11917c0
@dependabot
chore(deps-dev): Bump tough-cookie from 4.1.2 to 4.1.3 in /infra (#3504)
1a6bbf7 
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Jordan-Nelson
chore: update mocktail to 1.0.0 (#3506)
3808552
@fjnoyp
fix(datastore): hot restart (#3497)
fa711da 
Ignore platform exceptions so that authenticator no longer freezes app with datastore on hot restart.

Co-authored-by: kyle <[email protected]>
@NikaHsn
fix(datastore): make event history list thread safe (#3509)
410e521 
Co-authored-by: Nika Hassani <[email protected]>
@dnys1
perf(auth): Fetch auth session (#3510)
4c6e5fe 
fix(auth): Fetch auth session performance

When a query is made to the credential store, we currently always hit the underlying store. However, due to the queuing nature of the store, if it's in a `success` state we can immediately return since we are guaranteed to have the latest data.
@ragingsquirrel3 ragingsquirrel3 requested a review from a team as a code owner August 7, 2023 20:01
ragingsquirrel3
ragingsquirrel3 commented Aug 7, 2023
View reviewed changes
packages/amplify/amplify_flutter/CHANGELOG.md
@@ -1,3 +1,11 @@
## 1.3.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callout: output of aft version-bump was "NEXT" here and did not actually change the version on amplify_flutter. I thought that would be odd, so I manually changed this to 1.3.1 and manually changed the version in amplify_flutter's pubspec. I'm open to other ideas for resolving this if not desired as we usually keep this changelog as a top-level changelog akin to release notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. That's a bug.

ragingsquirrel3
ragingsquirrel3 commented Aug 7, 2023
View reviewed changes
packages/amplify/amplify_flutter/pubspec.yaml
@@ -1,6 +1,6 @@
name: amplify_flutter
description: The top level Flutter package for the AWS Amplify libraries.
version: 1.3.0
version: 1.3.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment: did this manually

NikaHsn
NikaHsn previously approved these changes Aug 7, 2023
View reviewed changes
dnys1
dnys1 previously approved these changes Aug 7, 2023
View reviewed changes
@ragingsquirrel3 ragingsquirrel3 changed the base branch from chore/release/aug07 to stable August 7, 2023 20:18
@ragingsquirrel3 ragingsquirrel3 dismissed dnys1’s stale review August 7, 2023 20:18

The base branch was changed.

@ragingsquirrel3 ragingsquirrel3 dismissed NikaHsn’s stale review August 7, 2023 20:18

The base branch was changed.

chore(version): Bump version
b7c0d21 
- fix(auth): Android Hosted UI flakiness
- fix(auth): Remove `nonce` usage ([#3321](#3321))
- fix(datastore): hot restart ([#3497](#3497))
- fix(datastore): make event history list thread safe ([#3509](#3509))
- fix(push): Incorrect handling of simple alert ([#3502](#3502))
- perf(auth): Fetch auth session ([#3510](#3510))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@ragingsquirrel3 ragingsquirrel3 merged commit a15176d into aws-amplify:stable Aug 7, 2023
165 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnys1 dnys1 dnys1 approved these changes

@NikaHsn NikaHsn NikaHsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ragingsquirrel3 @NikaHsn @dnys1 @Equartey @Jordan-Nelson @fjnoyp