-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main
-> stable
#3031
Merged
Merged
Merge main
-> stable
#3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, structure members were generated in alphabetical order, but this causes issues for some protocols like `awsQuery` that require members to be serialized in a specific order. This commit changes the codegen to generate members in the order they are defined in the Smithy model.
Updates service client generation for `awsQuery` which does not explicitly set an `@httpTrait`.
Tests the `awsQuery` protocol via the STS service.
Blindly appending `Operation` to the end of an operation's name can create conflicts, like with CloudFormation where both `DescribeStacks` and `DescribeStacksOperation` are valid operations. This change makes it so that the operation name is only appended if doing so wouldn't create a conflict.
Fixes #2937 Adds `namespace` attribute to `build.gradle` files in accordance with [Android docs](https://developer.android.com/build/publish-library/prep-lib-release) for compatibility with Android Gradle Plugin (AGP) 8.0. See also: flutter/flutter#125181 (comment)
Makes further use of gitattributes to define Windows-specific files (which should always be checked out/in with CRLF endings). Further clarifies which
feat(smithy): `awsQuery` protocol
* ci: Migrate canaries to GitHub actions - Removes CircleCI config - Adds canaries workflow to GitHub actions - Consolidates Android emulator launching to shared action * Add full canary app + e2e flow * Install deps * Fix dependencies * Fix pull path * Try reuse canaries * Try fix Android * Try fix iOS * More fixes * More fixes * Fix * Fixes * Add DataStore test * Add back CircleCI config * Disable PR checks * Rename canary backend
Use `git diff` to check whether workflows have changed and also to print a nice diff when they have. Based on https://github.com/kevmoo/build_verify/blob/master/lib/src/impl.dart
Fixes #2946. Align logic with username/password login (https://github.com/aws-amplify/amplify-flutter/blob/a010c360376d062eba2c8ac4a01d04a88b555fec/packages/auth/amplify_auth_cognito_dart/lib/src/state/machines/sign_in_state_machine.dart#L539) and refresh AWS credentials upon succesful login.
* chore: Use `xcodes` in canaries The `xcversion` command, which is preinstalled on GH runners, is being deprecated: https://github.com/xcpretty/xcode-install. This migrates to the recommended replacement `xcodes`. * Fix command * Remove push
Transform network exceptions in the SDK layer so that individual plugin methods do not need to be wrapped.
* chore(secure_storage): migrate pigeon to kotlin * chore(secure_storage): migrate pigeon to swift * chore: update `.gitattributes` to ignore generated code * chore(secure_storage): fix file naming * chore: add todo for combining macOS and iOS code * chore: fix formatting in gitattributes * chore: update NSUserDefaults API to be sync
* chore(authenticator): add warning for delayed asyncConfig * chore: address PR comments Co-authored-by: Dillon Nys <[email protected]> --------- Co-authored-by: Dillon Nys <[email protected]>
Methods previously unawaited should be wrapped with `unawaited` not awaited.
Clean up serialization/deserialization by using guards and destructuring instead of a bunch of if checks.
Not really used for much right now so some breaking changes are okay. Migrate to sealed clsses and remove unnecessary methods.
Makes serialization more statically typed. Reduces conflation of Input and InputPayload types. And makes the serialization pipeline more clear overall by tightening API definitions.
Makes all `AmplifyException` category subtypes sealed.
chore: wait for addPlugin prior to configure Co-authored-by: Jordan Nelson <[email protected]>
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
approved these changes
May 11, 2023
HuiSF
approved these changes
May 11, 2023
HuiSF
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.