Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flutter): Export category interfaces #1384

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Feb 21, 2022

Issue #, if available:

Description of changes:

  • Exports the category interfaces from amplify_flutter which were public pre-0.3.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dnys1 dnys1 requested a review from a team as a code owner February 21, 2022 16:40
@ragingsquirrel3
Copy link
Contributor

request: Please remove this line from corresponding unit test https://github.com/aws-amplify/amplify-flutter/blob/main/packages/amplify_flutter/test/amplify_test.dart#L21 as I believe that will help ensure this does not get accidentally moved in the future and helps enforce that these are publicly visible w no workaround.

Copy link
Contributor

@ragingsquirrel3 ragingsquirrel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Approved with minor request.

@dnys1 dnys1 merged commit 4648ff9 into aws-amplify:main Feb 21, 2022
@dnys1 dnys1 deleted the fix/export-categories branch February 21, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants