test: confirm sign in tests #1176
Conversation
| @@ -105,6 +107,17 @@ abstract class AuthenticatorPage { | |||
| expect(expectCombinationNotFound, findsOneWidget); | |||
| } | |||
|
|
|||
| /// Then I see Invalid verification code | |||
| Future<void> expectInvalidVerificationCode() async { | |||
| if (Platform.isAndroid) { | |||
There was a problem hiding this comment.
It surprised me that the messages were different on iOS and Android. Seems like this is a bug. Not specific to the authenticator though.
There was a problem hiding this comment.
Here is where the message on Android is coming from - https://github.com/aws-amplify/amplify-android/blob/main/core/src/main/java/com/amplifyframework/auth/AuthException.java#L317
| final Stream<GraphQLResponse<String>> operation = Amplify.API.subscribe( | ||
| GraphQLRequest<String>(document: subscriptionDocument), | ||
| onEstablished: () { | ||
| subscriptionCompleter.complete(); |
There was a problem hiding this comment.
I assume you tested and this worked? When I tried this approach it hung.
There was a problem hiding this comment.
It hung some (most?) of the time but did seem to work some of the time. I have await subscriptionCompleter.future commented out and instead have await Future.delayed(const Duration(seconds: 1), () {}); as a temp solution.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.