feature(amplify_api): Graphql helpers, include parent and decode nested/parent values #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
October 6, 2021 10:37
…sted models from mutations, integ tests pass, still need to update queries and test them
…els with belongsTo, transform JSON in response for parents and children
Codecov Report
@@ Coverage Diff @@
## feature/graphql_helpers_updated #1055 +/- ##
===================================================================
+ Coverage 66.63% 66.77% +0.13%
===================================================================
Files 294 295 +1
Lines 10020 10065 +45
Branches 396 396
===================================================================
+ Hits 6677 6721 +44
- Misses 3203 3204 +1
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fjnoyp
approved these changes
Nov 10, 2021
| 'rating': 0, | ||
| 'comments': [ | ||
| { | ||
| 'serializedData': { |
There was a problem hiding this comment.
Thanks for writing all of the code to translate between JSON formats. Do you think it would have been better if we changed our own JSON instead to ensure total uniformity of JSON.
There was a problem hiding this comment.
long-term, aligning would be better, just don't have time right now to reconcile the datastore part and add extra codegen logic. This is the safest/easiest thing to do for now.
dnys1
approved these changes
Nov 11, 2021
HuiSF
approved these changes
Nov 11, 2021
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 15, 2021
* chore(amplify_api): GraphQL helper move dependencies (#729) * feat(amplify_api): GraphQL helper get query (#742) * feat(amplify_api): GraphQL Response Decoding (#763) * feat(amplify_api): GraphQL Query Helper - List (#771) * feat(amplify_api): GraphQL Mutate Helper - Create (#778) * feat(amplify_api): GraphQL Mutate Helper - Update (#779) * feat(amplify_api): GraphQL Mutate Helper - Delete (#780) * feat(amplify_api): GraphQL Helpers Integration Tests (#785) * fix(amplify_api): GraphQL Helper Clean Up (#803) * graphql helpers: slight refactor to datastore interface QueryFieldOpe… (#962) * Graphql helpers pagination helpers (#947) * Graphql helpers: query predicates translated to filters and conditions for GraphQL requests (#973) * chore(amplify_api): graphql helpers, add parent selection set for models with belongsTo, transform JSON in response for parents and children * chore(amplify_api): parse nested responses recursively * chore(amplify_api): make data nullable in graphql responses (#1007) * chore(amplify_api): graphql helpers, mutations on models with parents (#1004) * feat(amplify_api): Graphql helpers, include parent and decode nested/parent values (#1055) Co-authored-by: Elijah Quartey <[email protected]> BREAKING CHANGE: data field nullable in GraphQLResponse
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jan 26, 2022
* feat(amplify_api): model-based graphql helpers (#1076) * chore(amplify_api): GraphQL helper move dependencies (#729) * feat(amplify_api): GraphQL helper get query (#742) * feat(amplify_api): GraphQL Response Decoding (#763) * feat(amplify_api): GraphQL Query Helper - List (#771) * feat(amplify_api): GraphQL Mutate Helper - Create (#778) * feat(amplify_api): GraphQL Mutate Helper - Update (#779) * feat(amplify_api): GraphQL Mutate Helper - Delete (#780) * feat(amplify_api): GraphQL Helpers Integration Tests (#785) * fix(amplify_api): GraphQL Helper Clean Up (#803) * graphql helpers: slight refactor to datastore interface QueryFieldOpe… (#962) * Graphql helpers pagination helpers (#947) * Graphql helpers: query predicates translated to filters and conditions for GraphQL requests (#973) * chore(amplify_api): graphql helpers, add parent selection set for models with belongsTo, transform JSON in response for parents and children * chore(amplify_api): parse nested responses recursively * chore(amplify_api): make data nullable in graphql responses (#1007) * chore(amplify_api): graphql helpers, mutations on models with parents (#1004) * feat(amplify_api): Graphql helpers, include parent and decode nested/parent values (#1055) Co-authored-by: Elijah Quartey <[email protected]> BREAKING CHANGE: data field nullable in GraphQLResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains additional functionality for child/parent models in API graphql helpers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.