Skip to content

Commit

Permalink
revert debugs. Removed latest flag
Browse files Browse the repository at this point in the history
  • Loading branch information
Equartey committed Jul 11, 2024
1 parent 7c90d7d commit 7b45bb7
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/composite_actions/launch_ios_simulator/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Launches an iOS simulator and caches it for further action runs
inputs:
ios-version:
description: The iOS version
default: "latest"
default: "17.5"
runs:
using: "node16"
main: "dist/index.mjs"
14 changes: 2 additions & 12 deletions .github/composite_actions/launch_ios_simulator/dist/main.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/workflows/actions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
matrix:
ios-version:
- "15.0"
- "latest"
- "17.5"
steps:
- name: Git Checkout
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # 3.6.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/amplify_canaries.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ jobs:
flutter-version: "3.19.0"
ios-version:
- "15.0"
- "latest"
- "17.5"
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # 3.6.0
with:
Expand Down
3 changes: 0 additions & 3 deletions actions/bin/launch_ios_simulator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Future<void> main(List<String> args) => wrapMain(launch);
Future<void> launch() async {
await installXcodes();
final iosVersionArg = core.getInput('ios-version');
core.info('debug:: iosVersionArg: $iosVersionArg');
final iosVersion =
iosVersionArg == 'latest' ? await getLatest() : 'iOS $iosVersionArg';
core.info('Launching simulator for $iosVersion');
Expand Down Expand Up @@ -103,8 +102,6 @@ Future<void> installXcodes() => core.withGroup('Install xcodes', () async {
});

Future<String> getLatest() async {
final debug = await exec.exec('/bin/sh', ['-c', r'xcodes runtimes']);
core.info('debug:: ${debug.stdout}');
final version = await exec
.exec('/bin/sh', ['-c', r'xcodes runtimes | grep -e "iOS" | tail -n 1']);
if (version.exitCode != 0) {
Expand Down
2 changes: 1 addition & 1 deletion actions/bin/launch_ios_simulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Launches an iOS simulator and caches it for further action runs
inputs:
ios-version:
description: The iOS version
default: "latest"
default: "17.5"
runs:
using: "node16"
main: "dist/index.mjs"

0 comments on commit 7b45bb7

Please sign in to comment.