Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove sigint handling for gen2 cli in e2e tests #905

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

atierian
Copy link
Member

@atierian atierian commented Nov 7, 2024

Problem

Sending SIGINT (ctrl + c) to the sandbox process no longer prompts the user.

Would you like to delete all the resources in your sandbox environment (This cannot be undone)?
> 

Instead it now prints guidance.

Stopping the sandbox process. To delete the sandbox, run npx ampx sandbox delete

Some of our E2E tests expect that prompt and throw if it's not.

Description of changes

Don't expect the prompt.

Codegen Paramaters Changed or Added

N/A

Issue #, if available

Related Backend PR:

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.
  • Changes adhere to the GraphQL Spec and supports the GraphQL types type, input, enum, interface, union and scalar types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian changed the title test: remove sigint handling for cli in gen2 e2e test test: remove sigint handling for gen2 cli in e2e tests Nov 7, 2024
@atierian atierian marked this pull request as ready for review November 7, 2024 17:46
@atierian atierian requested a review from a team as a code owner November 7, 2024 17:46
@atierian atierian enabled auto-merge (squash) November 12, 2024 05:02
@tejas2008 tejas2008 requested review from p5quared and tejas2008 and removed request for p5quared November 14, 2024 16:38
@atierian atierian requested review from p5quared and a team and removed request for tejas2008 November 14, 2024 16:40
@atierian atierian merged commit b92c1bf into main Nov 14, 2024
5 checks passed
@palpatim palpatim deleted the fix-sigint-handling branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants