Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove beta canaries #1141

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: remove beta canaries #1141

merged 1 commit into from
Nov 30, 2023

Conversation

letsbelopez
Copy link
Contributor

@letsbelopez letsbelopez commented Nov 30, 2023

Problem

The CLI doesn't use the beta tag anymore, so the beta canaries are now useless.

Solution

Remove the beta canaries.

We will add "beta equivalent" canaries if there is a solution in the CLI for the use case.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner November 30, 2023 17:52
@codecov-commenter
Copy link

Codecov Report

Merging #1141 (7619842) into main (3064fec) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1141   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         150      150           
  Lines        6112     6112           
  Branches     1836     1836           
=======================================
  Hits         5737     5737           
  Misses        357      357           
  Partials       18       18           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3064fec...7619842. Read the comment docs.

@letsbelopez letsbelopez merged commit e2e5f41 into main Nov 30, 2023
11 checks passed
@letsbelopez letsbelopez deleted the deprecate-beta-canary branch November 30, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants