Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add use client directive option to form renderer #1112

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

sdstolworthy
Copy link
Contributor

Adds the 'use client'; directive as an option when rendering react forms. This makes the forms more usable in next js components.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdstolworthy sdstolworthy requested a review from a team as a code owner October 19, 2023 16:07
Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a unit test / snapshot?

@codecov-commenter
Copy link

Codecov Report

Merging #1112 (79b4e07) into main (fdeeb89) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   93.80%   93.84%   +0.03%     
==========================================
  Files         149      149              
  Lines        6089     6091       +2     
  Branches     1834     1835       +1     
==========================================
+ Hits         5712     5716       +4     
+ Misses        358      357       -1     
+ Partials       19       18       -1     
Files Coverage Δ
.../codegen-ui-react/lib/forms/react-form-renderer.ts 97.72% <100.00%> (+0.93%) ⬆️
...ckages/codegen-ui-react/lib/react-render-config.ts 100.00% <ø> (ø)
...react/lib/react-studio-template-renderer-helper.ts 94.25% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdeeb89...79b4e07. Read the comment docs.

@sdstolworthy sdstolworthy merged commit 0cfef0f into main Oct 25, 2023
9 checks passed
@sdstolworthy sdstolworthy deleted the add-use-client-directive-option branch October 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants