feat: graphql support for collections #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## tagged-release/graphql-support #1027 +/- ##
==================================================================
+ Coverage 93.61% 93.73% +0.12%
==================================================================
Files 123 123
Lines 5591 5699 +108
Branches 1682 1713 +31
==================================================================
+ Hits 5234 5342 +108
Misses 337 337
Partials 20 20
Continue to review full report in Codecov by Sentry.
|
rtpascual
force-pushed
the
graphql-collection
branch
from
4beca5b
to
6ed7297
Compare
cwoolum
requested changes
Jun 23, 2023
packages/codegen-ui-react/lib/amplify-ui-renderers/collection.ts
Outdated
Show resolved
Hide resolved
packages/codegen-ui-react/lib/amplify-ui-renderers/collection.ts
Outdated
Show resolved
Hide resolved
packages/codegen-ui-react/lib/amplify-ui-renderers/collection.ts
Outdated
Show resolved
Hide resolved
bombguy
approved these changes
Jun 28, 2023
letsbelopez
reviewed
Jun 28, 2023
|
Should we be adding e2e tests for this new interface? |
There is a spike to see how we will be tackling e2e tests for GraphQL since the GraphQL calls will require a client. |
cwoolum
approved these changes
Jun 30, 2023
letsbelopez
pushed a commit
that referenced
this pull request
Jul 19, 2023
* feat: graphql support for collections * chore: refactor collection element to helper function and update addMappedImport
awinberg-aws
pushed a commit
that referenced
this pull request
Jul 19, 2023
* feat: graphql support for collections * chore: refactor collection element to helper function and update addMappedImport
letsbelopez
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: add graphql support for components * feat: add graphql support for create form (#1008) * feat: add graphql support for create form with relationships (#1010) * Update GraphQL API import and refactor GraphQL call expressions (#1012) * chore: update graphql api import * chore: refactor graphql call expressions to common function * chore: use pluralize for graphql list queries * feat: add graphql support for update form (#1015) * feat: add graphql support for update form * fix: update snapshot * feat: add more assertions to check for graphql support * fix: removing obselete snapshot * fix: force update mutation to use id var * chore: add declaration snapshots (#1018) * Update from main (#1025) * fix: parse operand value when field is number type (#1013) Co-authored-by: Justin Shih <[email protected]> * chore(release): v2.14.0 (#1014) Co-authored-by: Justin Shih <[email protected]> * fix: fix storage field prop import to storagemanager (#1016) Co-authored-by: Justin Shih <[email protected]> * chore(release): v2.14.1 (#1017) Co-authored-by: Justin Shih <[email protected]> * fix: add getOverrideProps to StorageManager (#1020) * fix: add getOverrideProps to StorageManager * fix: add overrideProps to Field component * Revert "fix: add overrideProps to Field component" This reverts commit 6393718. * chore(release): v2.14.2 (#1022) * fix: return theme declaration file from render func (#1023) Co-authored-by: Doesnt Matter <[email protected]> * fix: alias colliding imported model name in hasMany relationship (#1019) Co-authored-by: Justin Shih <[email protected]> * chore: update cli check --------- Co-authored-by: Justin Shih <[email protected]> Co-authored-by: Justin Shih <[email protected]> Co-authored-by: Charles Shin <[email protected]> Co-authored-by: David Lopez <[email protected]> Co-authored-by: Doesnt Matter <[email protected]> Co-authored-by: Roshane Pascual <[email protected]> * feat: update GraphqlRenderConfig to use separate props for each file path * feat: graphql support for collections (#1027) * feat: graphql support for collections * chore: refactor collection element to helper function and update addMappedImport * feat: adding graphql support for update forms with relationship (#1030) * fix: wrapping list graphql result for await (#1032) * feat: add graphql support for relationship forms with autocomplete field * fix: autocomplete options prop using incorrect records (#1035) * feat: add graphql support for relationship forms with autocomplete field * fix: autocomplete options prop using incorrect records * feat: add helpers to identify api dependencies * fix: use related model name instead of field in generating graphql qu… (#1039) * fix: use related model name instead of field in generating graphql queries * fix: updating invalid schema in integ test * feat: exit early in integ test failure * fix: lowering nyc coverage threshold --------- Co-authored-by: Albert Winberg <[email protected]> Co-authored-by: Roshane Pascual <[email protected]> Co-authored-by: Charles Shin <[email protected]> Co-authored-by: awinberg-aws <[email protected]> Co-authored-by: Justin Shih <[email protected]> Co-authored-by: Justin Shih <[email protected]> Co-authored-by: David Lopez <[email protected]> Co-authored-by: Roshane Pascual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Customers who do not use DataStore are not able to create collections with GraphQL APIs.
Solution
Conditionally generate needed code for GraphQL APIs rather than using the DataStore library for collections.
Additional Notes
Links
Ticket
GitHub issue _____
Other links
Verification
Manual tests
Automated tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.