Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen-ui): fix multiple has one relationships #1005

Merged
merged 2 commits into from
May 2, 2023

Conversation

cwoolum
Copy link
Contributor

@cwoolum cwoolum commented May 2, 2023

Problem

If a customer has multiple hasOne relationships for the same model, we currently default to the first field.

Solution

This adds an additional check to ensure that the field selected also uses the same key.

Additional Notes

No

Links

Ticket

GitHub issue: N/A

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cwoolum cwoolum marked this pull request as ready for review May 2, 2023 19:01
@cwoolum cwoolum requested a review from a team as a code owner May 2, 2023 19:01
Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@letsbelopez letsbelopez merged commit 96b7b9d into main May 2, 2023
@letsbelopez letsbelopez deleted the hotfix/support-multiple-has-one branch May 2, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants