Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse operand value when field is number type #1013

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented May 19, 2023

Problem

comparing equality with filter operand as string returns false. 0 == '0'

Solution

Parse operand value when field type is a number

Links

Ticket

GitHub issue _____

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner May 19, 2023 15:45
@codecov-commenter
Copy link

Codecov Report

Merging #1013 (3487793) into main (b3f340a) will increase coverage by 12.45%.
The diff coverage is 93.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1013       +/-   ##
===========================================
+ Coverage   81.26%   93.71%   +12.45%     
===========================================
  Files         121      122        +1     
  Lines        5369     5424       +55     
  Branches     1599     1618       +19     
===========================================
+ Hits         4363     5083      +720     
+ Misses        935      323      -612     
+ Partials       71       18       -53     
Impacted Files Coverage Δ
...react/lib/forms/form-renderer-helper/form-state.ts 98.84% <ø> (+23.98%) ⬆️
...b/forms/form-renderer-helper/render-array-field.ts 100.00% <ø> (+86.76%) ⬆️
.../codegen-ui-react/lib/forms/react-form-renderer.ts 96.46% <ø> (+25.61%) ⬆️
...ges/codegen-ui/lib/required-dependency-provider.ts 0.00% <ø> (ø)
...ages/codegen-ui-react/lib/utils/storage-manager.ts 22.22% <22.22%> (ø)
...m-to-component/map-form-definition-to-component.ts 88.46% <75.00%> (-2.85%) ⬇️
.../forms/form-renderer-helper/event-handler-props.ts 99.13% <100.00%> (+36.03%) ⬆️
...ct/lib/forms/form-renderer-helper/event-targets.ts 100.00% <100.00%> (+65.11%) ⬆️
...act/lib/forms/form-renderer-helper/model-values.ts 91.97% <100.00%> (+72.22%) ⬆️
.../lib/forms/form-renderer-helper/render-checkers.ts 100.00% <100.00%> (ø)
... and 11 more

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e23c0c...3487793. Read the comment docs.

@Jshhhh Jshhhh merged commit ad9ba60 into main May 19, 2023
@Jshhhh Jshhhh deleted the parse-operand branch May 19, 2023 17:00
bombguy added a commit that referenced this pull request Jun 19, 2023
* fix: parse operand value when field is number type (#1013)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.0 (#1014)

Co-authored-by: Justin Shih <[email protected]>

* fix: fix storage field prop import to storagemanager (#1016)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.1 (#1017)

Co-authored-by: Justin Shih <[email protected]>

* fix: add getOverrideProps to StorageManager (#1020)

* fix: add getOverrideProps to StorageManager

* fix: add overrideProps to Field component

* Revert "fix: add overrideProps to Field component"

This reverts commit 6393718.

* chore(release): v2.14.2 (#1022)

* fix: return theme declaration file from render func (#1023)

Co-authored-by: Doesnt Matter <[email protected]>

* fix: alias colliding imported model name in hasMany relationship (#1019)

Co-authored-by: Justin Shih <[email protected]>

* chore: update cli check

---------

Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Charles Shin <[email protected]>
Co-authored-by: David Lopez <[email protected]>
Co-authored-by: Doesnt Matter <[email protected]>
Co-authored-by: Roshane Pascual <[email protected]>
rtpascual added a commit that referenced this pull request Jun 23, 2023
* fix: parse operand value when field is number type (#1013)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.0 (#1014)

Co-authored-by: Justin Shih <[email protected]>

* fix: fix storage field prop import to storagemanager (#1016)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.1 (#1017)

Co-authored-by: Justin Shih <[email protected]>

* fix: add getOverrideProps to StorageManager (#1020)

* fix: add getOverrideProps to StorageManager

* fix: add overrideProps to Field component

* Revert "fix: add overrideProps to Field component"

This reverts commit 6393718.

* chore(release): v2.14.2 (#1022)

* fix: return theme declaration file from render func (#1023)

Co-authored-by: Doesnt Matter <[email protected]>

* fix: alias colliding imported model name in hasMany relationship (#1019)

Co-authored-by: Justin Shih <[email protected]>

* chore: update cli check

* chore: add specific cypress version to fix 12.15.0 bug (#1028)

---------

Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Charles Shin <[email protected]>
Co-authored-by: David Lopez <[email protected]>
Co-authored-by: Doesnt Matter <[email protected]>
letsbelopez added a commit that referenced this pull request Jul 19, 2023
* fix: parse operand value when field is number type (#1013)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.0 (#1014)

Co-authored-by: Justin Shih <[email protected]>

* fix: fix storage field prop import to storagemanager (#1016)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.1 (#1017)

Co-authored-by: Justin Shih <[email protected]>

* fix: add getOverrideProps to StorageManager (#1020)

* fix: add getOverrideProps to StorageManager

* fix: add overrideProps to Field component

* Revert "fix: add overrideProps to Field component"

This reverts commit 6393718.

* chore(release): v2.14.2 (#1022)

* fix: return theme declaration file from render func (#1023)

Co-authored-by: Doesnt Matter <[email protected]>

* fix: alias colliding imported model name in hasMany relationship (#1019)

Co-authored-by: Justin Shih <[email protected]>

* chore: update cli check

---------

Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Charles Shin <[email protected]>
Co-authored-by: David Lopez <[email protected]>
Co-authored-by: Doesnt Matter <[email protected]>
Co-authored-by: Roshane Pascual <[email protected]>
letsbelopez added a commit that referenced this pull request Jul 19, 2023
* feat: add graphql support for components

* feat: add graphql support for create form (#1008)

* feat: add graphql support for create form with relationships (#1010)

* Update GraphQL API import and refactor GraphQL call expressions (#1012)

* chore: update graphql api import

* chore: refactor graphql call expressions to common function

* chore: use pluralize for graphql list queries

* feat: add graphql support for update form (#1015)

* feat: add graphql support for update form

* fix: update snapshot

* feat: add more assertions to check for graphql support

* fix: removing obselete snapshot

* fix: force update mutation to use id var

* chore: add declaration snapshots (#1018)

* Update from main (#1025)

* fix: parse operand value when field is number type (#1013)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.0 (#1014)

Co-authored-by: Justin Shih <[email protected]>

* fix: fix storage field prop import to storagemanager (#1016)

Co-authored-by: Justin Shih <[email protected]>

* chore(release): v2.14.1 (#1017)

Co-authored-by: Justin Shih <[email protected]>

* fix: add getOverrideProps to StorageManager (#1020)

* fix: add getOverrideProps to StorageManager

* fix: add overrideProps to Field component

* Revert "fix: add overrideProps to Field component"

This reverts commit 6393718.

* chore(release): v2.14.2 (#1022)

* fix: return theme declaration file from render func (#1023)

Co-authored-by: Doesnt Matter <[email protected]>

* fix: alias colliding imported model name in hasMany relationship (#1019)

Co-authored-by: Justin Shih <[email protected]>

* chore: update cli check

---------

Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Charles Shin <[email protected]>
Co-authored-by: David Lopez <[email protected]>
Co-authored-by: Doesnt Matter <[email protected]>
Co-authored-by: Roshane Pascual <[email protected]>

* feat: update GraphqlRenderConfig to use separate props for each file path

* feat: graphql support for collections (#1027)

* feat: graphql support for collections

* chore: refactor collection element to helper function and update addMappedImport

* feat: adding graphql support for update forms with relationship (#1030)

* fix: wrapping list graphql result for await (#1032)

* feat: add graphql support for relationship forms with autocomplete field

* fix: autocomplete options prop using incorrect records (#1035)

* feat: add graphql support for relationship forms with autocomplete field

* fix: autocomplete options prop using incorrect records

* feat: add helpers to identify api dependencies

* fix: use related model name instead of field in generating graphql qu… (#1039)

* fix: use related model name instead of field in generating graphql queries

* fix: updating invalid schema in integ test

* feat: exit early in integ test failure

* fix: lowering nyc coverage threshold

---------

Co-authored-by: Albert Winberg <[email protected]>
Co-authored-by: Roshane Pascual <[email protected]>
Co-authored-by: Charles Shin <[email protected]>
Co-authored-by: awinberg-aws <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: Justin Shih <[email protected]>
Co-authored-by: David Lopez <[email protected]>
Co-authored-by: Roshane Pascual <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants