fix: improve instanceof checks to support custom transformers #9970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9970 +/- ##
==========================================
+ Coverage 54.17% 54.21% +0.04%
==========================================
Files 835 834 -1
Lines 46117 46068 -49
Branches 9839 9835 -4
==========================================
- Hits 24982 24975 -7
+ Misses 19144 19105 -39
+ Partials 1991 1988 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lazpavel
approved these changes
Mar 15, 2022
packages/amplify-graphql-transformer-core/src/cdk-compat/file-asset.ts
Outdated
Show resolved
Hide resolved
This commit updates two instanceof checks to instead check the constructor name. This is done to better support custom transformers. Because custom transformers import/require potentially different copies of the transformer modules, the instanceof checks do not work. This required v2 custom transformers to rely on NODE_PATH hacks and other workarounds. Refs: #9362
jhockett
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates two
instanceofchecks to instead checkthe constructor name. This is done to better support custom
transformers. Because custom transformers
import/requirepotentially different copies of the transformer modules,
the
instanceofchecks do not work. This required v2 customtransformers to rely on
NODE_PATHhacks and otherworkarounds.
Fixes: #9362