Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate rest apis with protected routes on push #9068

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett commented Nov 24, 2021

Description of changes

REST APIs that have a consolidated policy stack which have not yet been migrated fail to regenerate the policy stack when pushing with 7.5.0 - 7.5.4.

To workaround, migrate the REST API with amplify update api.

Fixes #9104

Issue #, if available

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett marked this pull request as ready for review November 26, 2021 21:08
@jhockett jhockett requested a review from a team as a code owner November 26, 2021 21:08
@akshbhu akshbhu merged commit 62b4436 into aws-amplify:master Nov 29, 2021
@jhockett jhockett deleted the policy-stack-fix branch November 30, 2021 01:43
akshbhu pushed a commit that referenced this pull request Nov 30, 2021
* fix: migrate rest apis with protected routes on push

* fix: gracefully exit after 'no' to REST API migration
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

👋 Hi, this pull request was referenced in the v7.5.5 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.5.5.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Dec 1, 2021
@xyklex
Copy link

xyklex commented Dec 1, 2021

Good timing 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
3 participants