fix: headless api migration #8992

akshbhu · 2021-11-21T03:16:12Z

Description of changes

bug fix in headless migration
migration tests

Issue #, if available

Description of how you validated changes

Checklist

PR description included
yarn test passes
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)
New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

packages/amplify-category-api/src/provider-utils/awscloudformation/utils/getAppSyncApiName.ts

sachscode · 2021-11-21T03:25:24Z

packages/amplify-category-api/src/index.ts

+      if (!(await checkAppsyncApiResourceMigration(context, resourceName, true))) {
+        printer.error('Update operations only work on migrated projects. Run "amplify update api" and opt for migration.');
+        exitOnNextTick(0);
+      }
      await getCfnApiArtifactHandler(context).updateArtifacts(await validateUpdateApiRequest(headlessPayload));


Does validateUpdateApiRequest return a bool ?

it return a payload , other wise will throw error , if the payload doesn't matches schema

packages/amplify-category-api/src/provider-utils/awscloudformation/utils/getAppSyncApiName.ts

codecov-commenter · 2021-11-21T04:13:39Z

Codecov Report

Merging #8992 (445cb28) into api-ext-rebase (984b554) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           api-ext-rebase    #8992   +/-   ##
===============================================
  Coverage           55.48%   55.48%           
===============================================
  Files                 883      883           
  Lines               49925    49925           
  Branches            10750    10750           
===============================================
  Hits                27700    27700           
  Misses              20182    20182           
  Partials             2043     2043

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984b554...445cb28. Read the comment docs.

* feat: extensibility for Amplify API (#8954) * feat: REST API extensibility (#8958) * fix: rebase fixes and bugs (#8960) * fix: rebase fixes and bugs * fix: service walkthrough call for appsync * fix: enable skeleton generation transformerFF is false (#8967) * feat: add min / max selection to prompter.pick (#8971) * fix: error handling, various bugs (#8976) * fix: tsconfig changes and renames (#8975) * fix: asana bug fixes * chore: allow js to false * fix: migration flow and cfn params when user pool groups are present, types (#8981) * fix: cfn parameters when user pool groups are present * fix: policy generation for user pool groups * fix: update types * test: fix project deletion even if meta validation fails * fix: rest iam policy roles array, bump ext helper types version (#8983) * fix: headless api migration (#8992) * fix: schema path inconsistencies, guest permissions, e2e * fix: api migration version e2es (#9000) Co-authored-by: John Hockett <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: jhockett <[email protected]>

* Api ext rebase 3 (#9001) * feat: extensibility for Amplify API (#8954) * feat: REST API extensibility (#8958) * fix: rebase fixes and bugs (#8960) * fix: rebase fixes and bugs * fix: service walkthrough call for appsync * fix: enable skeleton generation transformerFF is false (#8967) * feat: add min / max selection to prompter.pick (#8971) * fix: error handling, various bugs (#8976) * fix: tsconfig changes and renames (#8975) * fix: asana bug fixes * chore: allow js to false * fix: migration flow and cfn params when user pool groups are present, types (#8981) * fix: cfn parameters when user pool groups are present * fix: policy generation for user pool groups * fix: update types * test: fix project deletion even if meta validation fails * fix: rest iam policy roles array, bump ext helper types version (#8983) * fix: headless api migration (#8992) * fix: schema path inconsistencies, guest permissions, e2e * fix: api migration version e2es (#9000) Co-authored-by: John Hockett <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: jhockett <[email protected]> * fix: add missing ref call during rest stack generation, path casing (#9002) * fix: updates schema path on update api (#9005) * fix: api7 and api-migration tests (#9006) * fix: updates resource to resources and remove green ticks (#9007) * fix: overriding multiple userPoolGroups, ext helper type, lambda cfn (#9008) * fix: multiple userPoolGroups overwriting eachother * chore: update exported ext helper type * fix: lambda permissions not being generated * test: moved migration test and fixed the workflow (#9010) * test: moved migration test and fixed the workflow * test: remove jest settimeout Co-authored-by: AmmarKarachi <[email protected]> * fix: add missing property on path in cfn (#9011) * test: fixed integ test walkthrough (#9012) Co-authored-by: AmmarKarachi <[email protected]> * test: separate migration test helper from e2e (#9014) * fix: prediction migration test fix (#9015) * test: fix api_5.test.ts (#9017) * fix: single userpoolgroup name is iterated instead of being used (#9020) Co-authored-by: Sachin Panemangalore <[email protected]> * test: add missing option to e2e test (#9024) * fix: bucket parameters fetch logic (#9027) * fix: bucket parameters fetch logic * fix: address comments * fix: bucket parameters fetch logic (#9028) * fix: multiselect returns array when autoselecting (#9029) * fix: APIGW overrides package.json (#9032) * fix: package json dependencies * chore: new line at end of package.json * fix: migration of Admin Queries on override command (#9031) * fix: migration of Admin Queries on override command * fix: address feedback * feat: descoped http and functions override (#9035) * fix: address feedback (#9038) * fix: addressed comments (#9039) * fix: addressed comments * Update packages/amplify-provider-awscloudformation/src/download-api-models.ts Co-authored-by: Ammar <[email protected]> Co-authored-by: Ammar <[email protected]> Co-authored-by: akshbhu <[email protected]> Co-authored-by: John Hockett <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: jhockett <[email protected]> Co-authored-by: AmmarKarachi <[email protected]> Co-authored-by: Sachin Panemangalore <[email protected]> Co-authored-by: Sachin Panemangalore <[email protected]>

github-actions · 2021-11-23T21:30:53Z

👋 Hi, this pull request was referenced in the v7.5.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.5.0.

akshbhu added 5 commits November 20, 2021 14:33

feat: migration tests for api

33b3cfb

fix: headless migration and migration tests

db896fc

fix: revert migration test file

6120a9c

fix: migration tests for gql ext

35d5f33

fix: removed snapshot

f342aea

akshbhu requested a review from a team as a code owner November 21, 2021 03:16

akshbhu changed the title ~~Api ext migration~~ fix: headless api migration Nov 21, 2021

sachscode reviewed Nov 21, 2021

View reviewed changes

fix: address comments

47253d9

sachscode approved these changes Nov 21, 2021

View reviewed changes

jhockett reviewed Nov 21, 2021

View reviewed changes

packages/amplify-category-api/src/provider-utils/awscloudformation/utils/getAppSyncApiName.ts Outdated Show resolved Hide resolved

fix: improves error mmessage

445cb28

jhockett approved these changes Nov 21, 2021

View reviewed changes

jhockett merged commit 0d19da8 into aws-amplify:api-ext-rebase Nov 21, 2021

akshbhu added a commit to akshbhu/amplify-cli that referenced this pull request Nov 21, 2021

fix: headless api migration (aws-amplify#8992)

f59aafd

akshbhu added a commit that referenced this pull request Nov 21, 2021

fix: headless api migration (#8992)

e1b4cf7

jhockett pushed a commit to jhockett/amplify-cli that referenced this pull request Nov 21, 2021

fix: headless api migration (aws-amplify#8992)

0f719d0

akshbhu added a commit that referenced this pull request Nov 21, 2021

fix: headless api migration (#8992)

5661e6e

akshbhu added a commit to akshbhu/amplify-cli that referenced this pull request Nov 21, 2021

fix: headless api migration (aws-amplify#8992)

b491161

github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: headless api migration #8992

fix: headless api migration #8992

akshbhu commented Nov 21, 2021

sachscode Nov 21, 2021

akshbhu Nov 21, 2021

codecov-commenter commented Nov 21, 2021

github-actions bot commented Nov 23, 2021

fix: headless api migration #8992

fix: headless api migration #8992

Conversation

akshbhu commented Nov 21, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

sachscode Nov 21, 2021

Choose a reason for hiding this comment

akshbhu Nov 21, 2021

Choose a reason for hiding this comment

codecov-commenter commented Nov 21, 2021

Codecov Report

github-actions bot commented Nov 23, 2021