fix: address initial comments #8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jhockett
reviewed
Nov 19, 2021
jhockett
reviewed
Nov 19, 2021
| @@ -464,7 +464,8 @@ export const updateWalkthrough = async (context): Promise<UpdateApiRequest> => { | |||
| if (await checkAppsyncApiResourceMigration(context, resourceName, true)) { | |||
| await context.amplify.invokePluginMethod(context, 'awscloudformation', undefined, 'compileSchema', [context, { forceCompile: true }]); | |||
| } else { | |||
| printer.warn(`The GraphQL API is using transformer version 1. Run 'amplify migrate api' to upgrade to transformer version 2.`); | |||
| printer.error('Update Operations works on migrated projects. Run amplify update api and opt for migration'); | |||
There was a problem hiding this comment.
Suggested change
| printer.error('Update Operations works on migrated projects. Run amplify update api and opt for migration'); | |
| printer.error('Update operations only work on migrated projects. Run "amplify update api" and opt for migration.'); |
jhockett
approved these changes
Nov 19, 2021
akshbhu
added a commit
to akshbhu/amplify-cli
that referenced
this pull request
Nov 19, 2021
* fix: address initial comments * Update settings.json * Update index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Address comments of this PR : #8916
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.