-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update aws-sdk, cdk, typescript dependency, regen yarn.lock #8739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review the entire yarn.lock file in detail, but the changes LGTM. The SDK and CDK have already published new versions, but I won't block this PR on that.
@@ -27,7 +27,7 @@ | |||
}, | |||
"dependencies": { | |||
"amplify-velocity-template": "1.4.5", | |||
"aws-sdk": "^2.963.0", | |||
"aws-sdk": "^2.1022.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is already up to 2.1024.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I update, these changes are from Friday :D
"@aws-cdk/custom-resources": "~1.124.0", | ||
"@aws-cdk/cx-api": "~1.124.0", | ||
"@aws-cdk/region-info": "~1.124.0", | ||
"@aws-cdk/assets": "~1.130.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like CDK is up to 1.131.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except I see some references to the older aws-sdk
version in the main yarn.lock
file and the older aws-cdk
version in graphql-transformers-e2e-tests/resources/jsonServer/yarn.lock
.
packages/graphql-transformers-e2e-tests/resources/jsonServer/yarn.lock
Outdated
Show resolved
Hide resolved
packages/graphql-transformers-e2e-tests/resources/jsonServer/yarn.lock
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #8739 +/- ##
==========================================
- Coverage 57.20% 57.01% -0.20%
==========================================
Files 757 757
Lines 42243 42935 +692
Branches 8659 9558 +899
==========================================
+ Hits 24166 24479 +313
+ Misses 17263 16544 -719
- Partials 814 1912 +1098
Continue to review full report at Codecov.
|
"@aws-cdk/core" "1.131.0" | ||
"@aws-cdk/cx-api" "1.131.0" | ||
constructs "^3.3.69" | ||
|
||
"@aws-cdk/aws-apigatewayv2@~1.124.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing ~1.124.0
references here and throughout the lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because published versions are the same as we've currently in package.json and monorepo seems to be not smart enought with yarn 1.x ? it is pulling in those deps from published npm...
….lock (aws-amplify#8739)" This reverts commit d8065a8.
* Revert "fix(amplify-category-auth): added username attributes to configure sms (#8624)" This reverts commit adb70b1. * Revert "Model vnext unit test update (#8749)" This reverts commit 8a308a8. * Revert "Revert "feat: version blocking for CLI (#8737)" (#8747)" This reverts commit 2d5110c. * Revert "chore: update aws-sdk, cdk, typescript dependency, regen yarn.lock (#8739)" This reverts commit d8065a8. * Revert "feat: version blocking for CLI (#8737)" This reverts commit b92cd32. * Revert "Remove pipelineFunction references in favor of resolvers (#8729)" This reverts commit a0295aa. * Revert "fix: move @model params to root stack and fix ds logical id (#8736)" This reverts commit df4408c. * Revert "fix(amplify-provider-awscloudformation): use amplify prompts for warnings (#8731)" This reverts commit 98840ec.
Description of changes
Some major dependencies are out of sync with version numbers this PR fixes it.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.