feat: overrides uniformity accross all the categories #8695

kaustavghosh06 · 2021-11-05T18:57:33Z

Rename "overrideProps" to "override"
Rename "props" parameter to "resources"
Remove "return props" requirement and test that it doesn't crash
"✔ Do you want to edit override.ts file now? (y/N)" should default to "true"
Support for: amplify build -> from amplify build-override
Changes are applied to all categories
use vm2 uniformly

akshbhu

Looks Good!

lgtm-com · 2021-11-05T19:21:59Z

This pull request introduces 1 alert and fixes 2 when merging 7cd8a75 into f0e3faa - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-11-05T20:20:24Z

This pull request introduces 2 alerts and fixes 2 when merging 001f039 into dec20eb - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

2 for Unused variable, import, function or class

codecov-commenter · 2021-11-05T20:27:05Z

Codecov Report

Merging #8695 (001f039) into extOverrides3 (dec20eb) will decrease coverage by 0.00%.
The diff coverage is 21.62%.

@@                Coverage Diff                @@
##           extOverrides3    #8695      +/-   ##
=================================================
- Coverage          56.32%   56.31%   -0.01%     
=================================================
  Files                834      834              
  Lines              47108    47122      +14     
  Branches            9435     9435              
=================================================
+ Hits               26532    26537       +5     
- Misses             19758    19767       +9     
  Partials             818      818

Impacted Files	Coverage Δ
...rmation/auth-stack-builder/auth-stack-transform.ts	`83.22% <0.00%> (+0.51%)`	⬆️
...h-stack-builder/user-pool-group-stack-transform.ts	`85.71% <0.00%> (+1.00%)`	⬆️
...c/overrides-manager/override-skeleton-generator.ts	`19.23% <0.00%> (ø)`
...ion/src/root-stack-builder/root-stack-transform.ts	`79.72% <0.00%> (+1.06%)`	⬆️
...dformation/cdk-stack-builder/s3-stack-transform.ts	`10.29% <12.50%> (+0.84%)`	⬆️
...formation/cdk-stack-builder/ddb-stack-transform.ts	`78.04% <31.25%> (-4.39%)`	⬇️
packages/amplify-cli/src/commands/build.ts	`87.09% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec20eb...001f039. Read the comment docs.

* feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <[email protected]>

* feat: FF for override stacks (#8228) * feat: root stack override (#8276) * feat: added root stack transformation * feat: adding root-stack-builder * feat: added e2e and migration tests * fix: minor fixes * fix: fixes unit tests * fix: address comments * feat: adding rootstack types to overrides helper package (#8298) * feat: ddb overrides and flow refactor * feat: ddb overrides * feat: add migration logic * fix: remove older files post migration * fix: address PR comments * fix: remove inquirer and use amplify prompts instead Co-authored-by: Ghosh <[email protected]> * chore: ddb walkthrough refactor and override tests (#8364) * chore: overrides ddb and walthrough refactor tests * chore: address pr comments Co-authored-by: Ghosh <[email protected]> * feat: Auth refactor to use cdk, eliminate EJS, overrides functionality (#8355) * feat: add auth override * fix: auth state unit tests working * feat: auth e2e fixes and migration e2e included * fix: fixes package name * fix: unit tests fix * fix: unit tests * fix: fixing overwritten files * fix: added vm2 and addressed comments * fix: minor fixes and e2e test for overrides * fix: cli-core unit test * fix: userPool group unit test * fix: minor refractor and comments * chore: lgtm warnings * fix: minor fixes * fix: unit tests * (feat) Override for S3 - ( includues refactor s3-walkthrough and migrate) (#8383) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: fixes dependsOn parameter and auth migration test (#8480) * fix: dependsOn fix * chore: address comments * chore: remove JSON parsing * fix: default migration set to true * fix: added public access to scoped packages (#8485) * fix: adds typescript json dependency (#8487) * fix: enable scoped packages in plugin platform (#8492) * fix: adds userPool resourceName instead of authResource (#8497) * fix: adds userPool resourceName instead of authResource * fix: roleName in userPool groups * (bug-fix/reconcile-headless) remove groupList from userInputs, fix single-group, deploy errors (#8501) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: userPool group template fixes (#8515) * fix: template and naming fixed * fix: addressed comments * (fix) Call Auth migration from S3 migration for all auth resources in S3 (#8511) * (fix) Call Auth migration from S3 migration for all auth resources used by S3 * (fix) use invokePluginMethod instead of direct category calls * (fix) unit-test for s3 migration Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) s3 add with no-auth resource should succeed (#8520) Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) amplify override storage fails with missing tsconfig.json (#8556) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: parameters file path and updates cloud backend with build (#8564) * fix: latest changes * feat: define custom resources with CDK or CFN (#8590) * feat: define custom resources with CDK or CFN * chore: fix lint errors * chore: address API review and PR feedback * chore: fix unit test * fix: update skeleton CDK sample app based on API-Review * chore: fix build errors * chore: fix unit tests * chore: addressed PR review comments * chore: update uuid package version Co-authored-by: Ghosh <[email protected]> * chore: add public access for custom package * fix: add npmignore to custom resource package and update archiver (#8596) Co-authored-by: Ghosh <[email protected]> * fix: alias attr bug and use enabled mfa * fix: tsc global install error * fix: broken unit tests * fix: bug fixes in external auth enable * test: unit tests + e2e tests for custom resources (#8602) * test: unit tests for custom resources * chore: remove empty unit test file * fix: add all required types in override-helper package * chore: update override helper dependencies * test: unit test for dependency management utils * test: add coverage data and add more unit tests for cfn dependency management * test: add E2E tests for custom resources * chore: address PR review comments Co-authored-by: Ghosh <[email protected]> * fix: admin UI test * feat: add get project info helper to overrides helper package (#8620) * feat: add get project info helper to overrides helper package * chore: address PR feedback Co-authored-by: Ghosh <[email protected]> * chore: update skeleton package json override dependencies (#8641) Co-authored-by: Ghosh <[email protected]> * feat: amplify export * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * feat: export + override reconciled * test: fixed test because of bad merge * fix: added back conditional conditional rebuild * refactor(amplify-provider-awscloudformation): renamed the files to fit * test: fixed idp add storage test * test: fixes type import * feat: extensibility for REST APIs (#8598) * fix: ext overrides2 storage-headless and predictions (#8622) * fix: broken path on build-override * fix: pushing multiple APIs at a time (#8663) * fix: capitalization for filter, e2e test (#8667) * fix: capitalization for filter * test: fix prompt wait text * fix: test fixes (#8647) * (fix) add predictions + advanced mode + identifyEntity fails because … (#8658) * (fix) add predictions + advanced mode + identifyEntity fails because predictions cfn is not created * (fix) fixed regression for pred update + storage * (fix) plugininfo integ tests * (fix) storage e2e tests 'Auth' to 'Authenticated' Co-authored-by: Sachin Panemangalore <[email protected]> * fix: stack generation logic when multiple paths ref same Lambda (#8673) * Apigw revert (#8690) * Revert "fix: stack generation logic when multiple paths ref same Lambda (#8673)" This reverts commit fdbab02. * Revert "fix: capitalization for filter, e2e test (#8667)" This reverts commit e4f83fc. * Revert "fix: pushing multiple APIs at a time (#8663)" This reverts commit 4ff68bb. * Revert "fix: broken path on build-override" This reverts commit 712c043. * Revert "feat: extensibility for REST APIs (#8598)" This reverts commit 9822117. * (fix) [storage-1.test]init a project and add S3 bucket with user pool groups and then update S3 bucket to add trigger (#8691) Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) storage unit-tests for prompter function change (#8693) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: asana bug fixes (#8692) * fix: asana bug fixes * chore: removes commmented code * feat: overrides uniformity accross all the categories (#8695) * feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <[email protected]> * Ext overrides3 storage headless migrate (#8696) * (fix) s3 cli-ux loop until permission selected * (fix) storage unit-tests for prompter function change * (fix) auto-migrate on headless s3 storage api * (fix) enable migration in headless only if required * (fix) unit-test failing because of path incorrect Co-authored-by: Sachin Panemangalore <[email protected]> * Ext overrides3 fix auth import s3 add (#8704) * (fix) add missing logic to validate auth requirements in storage * (fix) check for import auth * (fix) auth unit-tests couldnt find getImportedAuthProperties Co-authored-by: Sachin Panemangalore <[email protected]> * fix: fix configure project and custom policies api containers (#8703) * feat: add default descriptions to cfn templates for metrics tracking (#8702) * feat: add default descriptions to cfn temppaltes for metrics tracking * test: fix unit tests Co-authored-by: Ghosh <[email protected]> * fix: does not create build for ll (#8706) * test: fixing DDB E2E tests (#8707) * test: fixing DDB E2E tests * test: fix ddb import e2e test Co-authored-by: Ghosh <[email protected]> * fix: auth e2e tests (#8708) Co-authored-by: Ammar <[email protected]> * Consolidate types headless (#8698) * fix: consolidate types and auto migrate * fix: changed package name to extensiblity * fix: address comments * feat: consolidate dependent resource types in backend/ (#8709) * feat: consolidate dependent resource types in backend/ * chore: fix build.test.ts unit test Co-authored-by: Ghosh <[email protected]> * test: fix ddb import e2e tests (#8711) Co-authored-by: Ghosh <[email protected]> * Ext overrides3 fix storagee2es (#8715) * (fix) validate bucket name for headless * (fix) s3 e2e tests blocking because of singleSelect and multiSelect failure * (fix) s3 e2e tests blocking because of extraneous function selection prompt Co-authored-by: Sachin Panemangalore <[email protected]> * feat: change override.ts file to override.ts.sample in resources/ for pkg CLI to work (#8716) Co-authored-by: Ghosh <[email protected]> * fix: auth issue in export tests (#8710) * fix: auth issue in export tests * fix: address comments * Root stack fix (#8717) * fix: disable root stack update check * fix: root stack hash and helper package versions * (fix) graphql-schema predictions migration failure because of missing… (#8718) * (fix) graphql-schema predictions migration failure because of missing storage * (fix/cleanup) changed default for storage trigger to N, removed extraneous keydown Co-authored-by: Sachin Panemangalore <[email protected]> * fix: remove depending on conditional output variables from stacks (#8719) Co-authored-by: Ghosh <[email protected]> * fix: rebase conflicts * fix: auth e2e fixes * feat(amplify-cli-core): allow * in account and region in arn for custom policies (#8722) * fix(cli): fixed export pull command line (#8725) * fix: headless migrate auth (#8735) * Ext overrides4 storage e2e (#8740) * (fix) timeout in add lambda when lambda exists * (fix) override DDB StreamSpecification fails because of missing CFN * (fix) storage-5 build-overrides hang fix * (fix) storage-5.ts * (fix) help missing for storage overrides * (fix) storage_migration_update hangs * (fix) remove unintended ignoring of tests Co-authored-by: Sachin Panemangalore <[email protected]> * fix: migration test fixes (#8742) * fix: hooks + hosting e2e (#8743) * fix: hooks + hosting e2e * fix: address comments * test: update ignore pattern for build-tests, fix import ddb tests (#8744) * test(amplify-migration-tests): path fix for override-root file (#8745) * fix: update custom cdk seleton templates + format override skeleton file (#8752) * fix: update custom cdk seleton tempaltes + format override skeleton file * chore: revert package version chnge for cli-core Co-authored-by: Ghosh <[email protected]> * (fix) storage add walkthrough hanging in integ test (#8746) Co-authored-by: Sachin Panemangalore <[email protected]> * fix(amplify-category-auth): fixed the openId Connect proovider auth (#8753) * fix: fixed import_auth test (#8755) * fix: fixes auth migration e2e (#8756) * fix: fixes auth migration e2e * fix: signIn SignOut test * fix: remove no-override check for category transformations (#8765) Co-authored-by: Ghosh <[email protected]> * fix: init override test fix (#8768) * fix: amplify meta output for imported ddb, type fixes (#8767) * (fix) amplify status crashes when auth is legacy (#8769) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: build resources on pull even with no override flag passed + update skeleton package.json (#8771) * fix: build resources on pull even with no override flag passed * chore: update package versions of ext helper in skeleton package.json + ci/cd fix * fix: build resource during initialzing an env Co-authored-by: Ghosh <[email protected]> * fix: generate dynamic amplify resource types before building cdk code (#8778) Co-authored-by: Ghosh <[email protected]> * fix: hosting fix and changelog added (#8780) * feat: FF for override stacks (#8228) * feat: root stack override (#8276) * feat: added root stack transformation * feat: adding root-stack-builder * feat: added e2e and migration tests * fix: minor fixes * fix: fixes unit tests * fix: address comments * feat: adding rootstack types to overrides helper package (#8298) * feat: ddb overrides and flow refactor * feat: ddb overrides * feat: add migration logic * fix: remove older files post migration * fix: address PR comments * fix: remove inquirer and use amplify prompts instead Co-authored-by: Ghosh <[email protected]> * chore: ddb walkthrough refactor and override tests (#8364) * chore: overrides ddb and walthrough refactor tests * chore: address pr comments Co-authored-by: Ghosh <[email protected]> * feat: Auth refactor to use cdk, eliminate EJS, overrides functionality (#8355) * feat: add auth override * fix: auth state unit tests working * feat: auth e2e fixes and migration e2e included * fix: fixes package name * fix: unit tests fix * fix: unit tests * fix: fixing overwritten files * fix: added vm2 and addressed comments * fix: minor fixes and e2e test for overrides * fix: cli-core unit test * fix: userPool group unit test * fix: minor refractor and comments * chore: lgtm warnings * fix: minor fixes * fix: unit tests * (feat) Override for S3 - ( includues refactor s3-walkthrough and migrate) (#8383) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: fixes dependsOn parameter and auth migration test (#8480) * fix: dependsOn fix * chore: address comments * chore: remove JSON parsing * fix: default migration set to true * fix: added public access to scoped packages (#8485) * fix: adds typescript json dependency (#8487) * fix: enable scoped packages in plugin platform (#8492) * fix: adds userPool resourceName instead of authResource (#8497) * fix: adds userPool resourceName instead of authResource * fix: roleName in userPool groups * (bug-fix/reconcile-headless) remove groupList from userInputs, fix single-group, deploy errors (#8501) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: userPool group template fixes (#8515) * fix: template and naming fixed * fix: addressed comments * (fix) Call Auth migration from S3 migration for all auth resources in S3 (#8511) * (fix) Call Auth migration from S3 migration for all auth resources used by S3 * (fix) use invokePluginMethod instead of direct category calls * (fix) unit-test for s3 migration Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) s3 add with no-auth resource should succeed (#8520) Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) amplify override storage fails with missing tsconfig.json (#8556) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: parameters file path and updates cloud backend with build (#8564) * fix: latest changes * feat: define custom resources with CDK or CFN (#8590) * feat: define custom resources with CDK or CFN * chore: fix lint errors * chore: address API review and PR feedback * chore: fix unit test * fix: update skeleton CDK sample app based on API-Review * chore: fix build errors * chore: fix unit tests * chore: addressed PR review comments * chore: update uuid package version Co-authored-by: Ghosh <[email protected]> * chore: add public access for custom package * fix: add npmignore to custom resource package and update archiver (#8596) Co-authored-by: Ghosh <[email protected]> * fix: alias attr bug and use enabled mfa * fix: tsc global install error * fix: broken unit tests * fix: bug fixes in external auth enable * test: unit tests + e2e tests for custom resources (#8602) * test: unit tests for custom resources * chore: remove empty unit test file * fix: add all required types in override-helper package * chore: update override helper dependencies * test: unit test for dependency management utils * test: add coverage data and add more unit tests for cfn dependency management * test: add E2E tests for custom resources * chore: address PR review comments Co-authored-by: Ghosh <[email protected]> * fix: admin UI test * feat: add get project info helper to overrides helper package (#8620) * feat: add get project info helper to overrides helper package * chore: address PR feedback Co-authored-by: Ghosh <[email protected]> * chore: update skeleton package json override dependencies (#8641) Co-authored-by: Ghosh <[email protected]> * feat: amplify export * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * feat: export + override reconciled * test: fixed test because of bad merge * fix: added back conditional conditional rebuild * refactor(amplify-provider-awscloudformation): renamed the files to fit * test: fixed idp add storage test * test: fixes type import * feat: extensibility for REST APIs (#8598) * fix: ext overrides2 storage-headless and predictions (#8622) * fix: broken path on build-override * fix: pushing multiple APIs at a time (#8663) * fix: capitalization for filter, e2e test (#8667) * fix: capitalization for filter * test: fix prompt wait text * fix: test fixes (#8647) * (fix) add predictions + advanced mode + identifyEntity fails because … (#8658) * (fix) add predictions + advanced mode + identifyEntity fails because predictions cfn is not created * (fix) fixed regression for pred update + storage * (fix) plugininfo integ tests * (fix) storage e2e tests 'Auth' to 'Authenticated' Co-authored-by: Sachin Panemangalore <[email protected]> * fix: stack generation logic when multiple paths ref same Lambda (#8673) * Apigw revert (#8690) * Revert "fix: stack generation logic when multiple paths ref same Lambda (#8673)" This reverts commit fdbab02. * Revert "fix: capitalization for filter, e2e test (#8667)" This reverts commit e4f83fc. * Revert "fix: pushing multiple APIs at a time (#8663)" This reverts commit 4ff68bb. * Revert "fix: broken path on build-override" This reverts commit 712c043. * Revert "feat: extensibility for REST APIs (#8598)" This reverts commit 9822117. * (fix) [storage-1.test]init a project and add S3 bucket with user pool groups and then update S3 bucket to add trigger (#8691) Co-authored-by: Sachin Panemangalore <[email protected]> * (fix) storage unit-tests for prompter function change (#8693) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: asana bug fixes (#8692) * fix: asana bug fixes * chore: removes commmented code * feat: overrides uniformity accross all the categories (#8695) * feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <[email protected]> * Ext overrides3 storage headless migrate (#8696) * (fix) s3 cli-ux loop until permission selected * (fix) storage unit-tests for prompter function change * (fix) auto-migrate on headless s3 storage api * (fix) enable migration in headless only if required * (fix) unit-test failing because of path incorrect Co-authored-by: Sachin Panemangalore <[email protected]> * Ext overrides3 fix auth import s3 add (#8704) * (fix) add missing logic to validate auth requirements in storage * (fix) check for import auth * (fix) auth unit-tests couldnt find getImportedAuthProperties Co-authored-by: Sachin Panemangalore <[email protected]> * fix: fix configure project and custom policies api containers (#8703) * feat: add default descriptions to cfn templates for metrics tracking (#8702) * feat: add default descriptions to cfn temppaltes for metrics tracking * test: fix unit tests Co-authored-by: Ghosh <[email protected]> * fix: does not create build for ll (#8706) * test: fixing DDB E2E tests (#8707) * test: fixing DDB E2E tests * test: fix ddb import e2e test Co-authored-by: Ghosh <[email protected]> * fix: auth e2e tests (#8708) Co-authored-by: Ammar <[email protected]> * Consolidate types headless (#8698) * fix: consolidate types and auto migrate * fix: changed package name to extensiblity * fix: address comments * feat: consolidate dependent resource types in backend/ (#8709) * feat: consolidate dependent resource types in backend/ * chore: fix build.test.ts unit test Co-authored-by: Ghosh <[email protected]> * test: fix ddb import e2e tests (#8711) Co-authored-by: Ghosh <[email protected]> * Ext overrides3 fix storagee2es (#8715) * (fix) validate bucket name for headless * (fix) s3 e2e tests blocking because of singleSelect and multiSelect failure * (fix) s3 e2e tests blocking because of extraneous function selection prompt Co-authored-by: Sachin Panemangalore <[email protected]> * feat: change override.ts file to override.ts.sample in resources/ for pkg CLI to work (#8716) Co-authored-by: Ghosh <[email protected]> * fix: auth issue in export tests (#8710) * fix: auth issue in export tests * fix: address comments * Root stack fix (#8717) * fix: disable root stack update check * fix: root stack hash and helper package versions * (fix) graphql-schema predictions migration failure because of missing… (#8718) * (fix) graphql-schema predictions migration failure because of missing storage * (fix/cleanup) changed default for storage trigger to N, removed extraneous keydown Co-authored-by: Sachin Panemangalore <[email protected]> * fix: remove depending on conditional output variables from stacks (#8719) Co-authored-by: Ghosh <[email protected]> * fix: rebase conflicts * fix: auth e2e fixes * feat(amplify-cli-core): allow * in account and region in arn for custom policies (#8722) * fix(cli): fixed export pull command line (#8725) * fix: headless migrate auth (#8735) * Ext overrides4 storage e2e (#8740) * (fix) timeout in add lambda when lambda exists * (fix) override DDB StreamSpecification fails because of missing CFN * (fix) storage-5 build-overrides hang fix * (fix) storage-5.ts * (fix) help missing for storage overrides * (fix) storage_migration_update hangs * (fix) remove unintended ignoring of tests Co-authored-by: Sachin Panemangalore <[email protected]> * fix: migration test fixes (#8742) * fix: hooks + hosting e2e (#8743) * fix: hooks + hosting e2e * fix: address comments * test: update ignore pattern for build-tests, fix import ddb tests (#8744) * test(amplify-migration-tests): path fix for override-root file (#8745) * fix: update custom cdk seleton templates + format override skeleton file (#8752) * fix: update custom cdk seleton tempaltes + format override skeleton file * chore: revert package version chnge for cli-core Co-authored-by: Ghosh <[email protected]> * (fix) storage add walkthrough hanging in integ test (#8746) Co-authored-by: Sachin Panemangalore <[email protected]> * fix(amplify-category-auth): fixed the openId Connect proovider auth (#8753) * fix: fixed import_auth test (#8755) * fix: fixes auth migration e2e (#8756) * fix: fixes auth migration e2e * fix: signIn SignOut test * fix: remove no-override check for category transformations (#8765) Co-authored-by: Ghosh <[email protected]> * fix: init override test fix (#8768) * fix: amplify meta output for imported ddb, type fixes (#8767) * (fix) amplify status crashes when auth is legacy (#8769) Co-authored-by: Sachin Panemangalore <[email protected]> * fix: build resources on pull even with no override flag passed + update skeleton package.json (#8771) * fix: build resources on pull even with no override flag passed * chore: update package versions of ext helper in skeleton package.json + ci/cd fix * fix: build resource during initialzing an env Co-authored-by: Ghosh <[email protected]> * fix: generate dynamic amplify resource types before building cdk code (#8778) Co-authored-by: Ghosh <[email protected]> * fix: hosting fix and changelog added (#8780) * Fix/export pull e2e 2 (#8785) * test(amplify-e2e-tests): adding a setting * test(amplify-e2e-core): testlambda with latest codebase Co-authored-by: akshbhu <[email protected]> Co-authored-by: Kaustav Ghosh <[email protected]> Co-authored-by: Ghosh <[email protected]> Co-authored-by: Sachin Panemangalore <[email protected]> Co-authored-by: Akshay <[email protected]> Co-authored-by: Ammar <[email protected]> Co-authored-by: John Hockett <[email protected]> Co-authored-by: jhockett <[email protected]>

* feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <[email protected]>

kaustavghosh06 requested a review from a team as a code owner November 5, 2021 18:57

akshbhu approved these changes Nov 5, 2021

View reviewed changes

Ghosh added 2 commits November 5, 2021 12:54

feat: overrides uniformity accross all the categories

db9699e

chore: remove unneeded dependency

01b3ee1

kaustavghosh06 force-pushed the extOverrides3 branch from 7cd8a75 to 01b3ee1 Compare November 5, 2021 19:55

fix: apply override unformity to root-stack

001f039

kaustavghosh06 merged commit 61fbf7c into aws-amplify:extOverrides3 Nov 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: overrides uniformity accross all the categories #8695

feat: overrides uniformity accross all the categories #8695

kaustavghosh06 commented Nov 5, 2021

akshbhu left a comment

lgtm-com bot commented Nov 5, 2021

lgtm-com bot commented Nov 5, 2021

codecov-commenter commented Nov 5, 2021

feat: overrides uniformity accross all the categories #8695

feat: overrides uniformity accross all the categories #8695

Conversation

kaustavghosh06 commented Nov 5, 2021

akshbhu left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 5, 2021

lgtm-com bot commented Nov 5, 2021

codecov-commenter commented Nov 5, 2021

Codecov Report