Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rebase with Master Branch #8444

Merged
merged 58 commits into from
Oct 14, 2021
Merged

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Oct 14, 2021

Description of changes

Rebase with master

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-amplify-bot and others added 30 commits September 27, 2021 18:50
…lify#8068)

* Custom policy implementation

* feat: add custom policies file to function and API container

add custom policies file to function and API container, merge the custom policies to CFN template,
validation for regex of resources and actions in the custom policies file

* feat: changes for first PR

* feat: Some changes according to the PR comments

1. Add Json Schema to validate the customers input 2. some minor changes related to format issue 3.
error handle

* feat: replace env to current env in the resource when checkout and add env, and push

* feat: e2e test and replacing env

* feat: Minor changes for env replacement

* feat: remove changing env between env

* feat: Add cloudform type for type safety, move validation to provider-cloudformation, validation

* feat: remove some unused function and import, change regex for resource

* feat: Some changes according to the PR comment

* feat: changes according to PR comments

* feat: remove unused import

* feat: remove previous unused code

* feat: Changes according to PR comments

* feat: some changes according to PR comments

* feat: work on PR comments

* feat: rebase for conflict

* feat: rebase for failure of hooksmanager test failed

* feat: unit test

* feat: fix fail test

* feat: change default template of custom policies

* feat: fix failed test

* feat: PR comments

* feat: pr comments

* feat: fix failed test

* feat: PR comments from ED

Co-authored-by: Lu Han <[email protected]>
…ws-amplify#8371)

* fix: opensearch warning, add optional chaining to get api category

* fix: opensearch warning, add test with existing categories
danielleadams and others added 22 commits October 8, 2021 13:16
* feat(cli): add post env add plugin event

* chore(cli): run post env add hook on amplify init
* Revert "fix: fixes e2e bug (aws-amplify#7067)"

This reverts commit 18c9a31.

* Update packages/amplify-cli/src/context-manager.ts

added ? for type checking
…oyment bucket (aws-amplify#8145)

* fix(amplify-category-api): fixed api to reference stack name and deployment bucket

* fix: addressed pr comments
* Revert "feat(amplify-provider-awscloudformation): enable custom resolvers for v2 transformer (aws-amplify#8332)"

This reverts commit 1c73042.

* Revert "feat(amplify-provider-awscloudformation): merge user config with transform generated resolvers (aws-amplify#8262)"

This reverts commit f25abbf.
* fix: api containers on repushing does not fail
…fy#8373)

* feat(amplify-category-geo): use custom resource constructs
* fix(amplify-category-geo): remove pre-push hook
* fix(amplify-category-geo): move lambdas to separate files
* fix(amplify-category-geo): update stack test snapshots
* feat: added root stack transformation

* feat: adding root-stack-builder

* feat: added e2e and migration tests

* fix: minor fixes

* fix: fixes unit tests

* fix: address comments
* feat: ddb overrides

* feat: add migration logic

* fix: remove older files post migration

* fix: address PR comments

* fix: remove inquirer and use amplify prompts instead

Co-authored-by: Ghosh <[email protected]>
* chore: overrides ddb and walthrough refactor tests

* chore: address pr comments

Co-authored-by: Ghosh <[email protected]>
aws-amplify#8355)

* feat: add auth override

* fix: auth state unit tests working

* feat: auth e2e fixes and migration e2e included

* fix: fixes package name

* fix: unit tests fix

* fix: unit tests

* fix: fixing overwritten files

* fix: added vm2 and addressed comments

* fix: minor fixes and e2e test for overrides

* fix: cli-core unit test

* fix: userPool group unit test

* fix: minor refractor and comments

* chore: lgtm warnings

* fix: minor fixes

* fix: unit tests
@akshbhu akshbhu requested a review from a team as a code owner October 14, 2021 17:32
@akshbhu akshbhu changed the title OvExt rebase Chore: Rebase with Master Branch Oct 14, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 4 alerts when merging 447d002 into 5a2a702 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Polynomial regular expression used on uncontrolled data

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off merging until we figure out where the DDB overrides changes are

@jhockett jhockett self-requested a review October 14, 2021 18:29
Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, the changes are present. My mistake.

@akshbhu akshbhu merged commit e2d3c3b into aws-amplify:extOverrides Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.