Revert "fix(cli): better error message when trying to publish with CD configured in Amplify Console (#7874) #8106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f7e62df. The commit being reverted builds on top of another commit that is being reverted.
4 tasks
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #8106 +/- ##
==========================================
- Coverage 54.43% 54.42% -0.01%
==========================================
Files 664 663 -1
Lines 37838 37829 -9
Branches 7768 7767 -1
==========================================
- Hits 20597 20589 -8
+ Misses 16401 16400 -1
Partials 840 840 Continue to review full report at Codecov.
|
jhockett
approved these changes
Sep 7, 2021
|
👋 Hi, this pull request was referenced in the v5.5.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.5.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
… configured in Amplify Console (aws-amplify#7874) (aws-amplify#8106) * Revert "fix: handle case where there is no appId (aws-amplify#8049)" This reverts commit f7e62df. The commit being reverted builds on top of another commit that is being reverted. * Revert "fix(cli): better error message when trying to publish with CD configured in Amplify Console (aws-amplify#7874)" This reverts commit 4f03859. The commit being reverted causes a number of customer bug reports in verion 5.4.0. Co-authored-by: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#7874 is causing customer issues in v5.4.0. Revert the change for now.
Issue #, if available
#8092 and a couple duplicates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.