fix(amplify-category-auth): update attr mapping... #7979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivate key and attr mapping Cognito SDK takes null for the private key if users want to update everything but the private key and updating to reflect the correct attribute mapping for siwa fix #7793
Codecov Report
@@ Coverage Diff @@
## master #7979 +/- ##
=======================================
Coverage 53.70% 53.70%
=======================================
Files 563 563
Lines 28554 28554
Branches 5541 5541
=======================================
Hits 15336 15336
Misses 12221 12221
Partials 997 997
Continue to review full report at Codecov.
|
ammarkarachi
approved these changes
Aug 30, 2021
|
Reverting this change as it was merged by accident. @letsbelopez could you please open another PR with your changes? |
jhockett
added a commit
that referenced
this pull request
Sep 7, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v5.5.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.5.0. |
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
* fix(amplify-category-auth): fixes being able to update siwa w/ out private key and attr mapping Cognito SDK takes null for the private key if users want to update everything but the private key and updating to reflect the correct attribute mapping for siwa fix aws-amplify#7793 * fix(amplify-category-auth): enable update siwa w/ out private key Co-authored-by: David Lopez <[email protected]>
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…fy#7979)" (aws-amplify#8115) This reverts commit 94d2491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and update siwa w/ out needing to pass private key
Cognito SDK takes null for the private key if users want to update everything but the private key (for headless use)
and updating to reflect the correct attribute mapping for siwa.
fix #7793
Description of changes
Updating string-maps to reflect the new SIWA attr mapping. Updating the cfn template for the custom resource that updates SIWA identity provider. Cognito SDK can take a null value as the private key on an update. If null is passed all other values are updated but the private key. Makes it easier for users to update SIWA because the private key value may not be easy to reproduce. This matches what Cognito is doing in their console app.
Issue #, if available
#7793
Description of how you validated changes
Ran cli commands:
Ran tagged release for this fix with Amplify Console builds.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.