Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade node default runtime to 14 #7700

Merged
merged 3 commits into from
Jul 20, 2021
Merged

fix: upgrade node default runtime to 14 #7700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
274bc58
fix: upgrade node runtime to 14
michaelbrewer Jul 10, 2021
f09e105
Merge branch 'master' into lambda-runtime/move-to-node-14
michaelbrewer Jul 12, 2021
157f33a
test: set nodejs14 as the detault
michaelbrewer Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er-utils/awscloudformation/cloudformation-templates/pinpoint-cloudformation-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
}
},
"Handler": "index.handler",
"Runtime": "nodejs12.x",
"Runtime": "nodejs14.x",
"Timeout": "300",
"Role": {
"Fn::GetAtt": ["LambdaExecutionRole", "Arn"]
Expand Down
12 changes: 6 additions & 6 deletions packages/amplify-category-auth/resources/cloudformation-templates/auth-template.yml.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ Resources:
- ' }'
- '};'
Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- UserPoolClientRole
Expand Down Expand Up @@ -507,7 +507,7 @@ Resources:


Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- UserPoolClientRole
Expand Down Expand Up @@ -659,7 +659,7 @@ Resources:
- '} '

Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- UserPoolClientRole
Expand Down Expand Up @@ -758,7 +758,7 @@ Resources:
- '}'

Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- UserPoolClientRole
Expand Down Expand Up @@ -879,7 +879,7 @@ Resources:
- ' }'
- '};'
Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- MFALambdaRole
Expand Down Expand Up @@ -1039,7 +1039,7 @@ Resources:
- ' }'
- '};'
Handler: index.handler
Runtime: nodejs12.x
Runtime: nodejs14.x
Timeout: '300'
Role: !GetAtt
- OpenIdLambdaRole
Expand Down
2 changes: 1 addition & 1 deletion ...mplify-category-auth/resources/cloudformation-templates/user-pool-group-template.json.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
}
},
"Handler": "index.handler",
"Runtime": "nodejs12.x",
"Runtime": "nodejs14.x",
"Timeout": "300",
"Role": {
"Fn::GetAtt": [
Expand Down
2 changes: 1 addition & 1 deletion ...plify-category-predictions/provider-utils/awscloudformation/assets/identifyCFNGenerate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ function generateLambdaAccessForRekognition(identifyCFNFile, functionName, s3Res
},
},
Handler: 'index.handler',
Runtime: 'nodejs12.x',
Runtime: 'nodejs14.x',
Timeout: '300',
Role: {
'Fn::GetAtt': ['CollectionsLambdaExecutionRole', 'Arn'],
Expand Down
2 changes: 1 addition & 1 deletion ...ions/provider-utils/awscloudformation/cloudformation-templates/identify-template.json.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@
}
},
"Handler": "index.handler",
"Runtime": "nodejs12.x",
"Runtime": "nodejs14.x",
"Timeout": "300",
"Role": {
"Fn::GetAtt": [
Expand Down
2 changes: 1 addition & 1 deletion packages/amplify-e2e-tests/src/__tests__/migration/node.function.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('nodejs version migration tests', () => {

fs.writeFileSync(projectConfigFileName, projectConfigContent, 'utf-8');

// Write back the nodejs version to 'node10.x' to test migration
// Write back the nodejs version to 'node12.x' to test migration
michaelbrewer marked this conversation as resolved.
Show resolved Hide resolved
const authResourceName = Object.keys(meta.auth)[0];
const authStackFileName = path.join(
projectRoot,
Expand Down