Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amplify-appsync-simulator): string functions not called on items … #7636

Merged
merged 5 commits into from
Jul 12, 2021
Merged

fix(amplify-appsync-simulator): string functions not called on items … #7636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bea0cc
fix(amplify-appsync-simulator): string functions not called on items …
alichherawalla Jun 30, 2021
c5c6bed
Merge branch 'master' of https://github.com/aws-amplify/amplify-cli
alichherawalla Jul 2, 2021
9b8ab5a
feat(amplify-appsync-simulator): added toJavaString that accepts a st…
alichherawalla Jul 2, 2021
775b4c1
feat(amplify-appsync-simulator): map.keySet returns an a JavaArray wi…
alichherawalla Jul 2, 2021
baac61f
feat(amplify-appsync-simulator): using this.mapper in map.keySet
alichherawalla Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/amplify-appsync-simulator/src/__tests__/velocity/value-mapper/map.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { JavaArray } from './../../../velocity/value-mapper/array';
import { JavaMap } from '../../../velocity/value-mapper/map';
import { JavaString } from '../../../velocity/value-mapper/string';
import { map as mapper } from '../../../velocity/value-mapper/mapper';

describe('JavaMap', () => {
let identityMapper = jest.fn().mockImplementation(val => val);
Expand Down Expand Up @@ -66,6 +69,12 @@ describe('JavaMap', () => {
expect(map.keySet().toJSON()).toEqual(['foo', 'bar']);
});

it('keySet returns a JavaArray with each element of type JavaString', () => {
const obj = { foo: 'Foo Value', bar: 'Bar Value' };
const map = new JavaMap(obj, mapper);
expect(map.keySet()).toEqual(new JavaArray([new JavaString('foo'), new JavaString('bar')], mapper));
});

it('put', () => {
const map = new JavaMap({}, identityMapper);
map.put('foo', 'Foo Value');
Expand Down
2 changes: 1 addition & 1 deletion packages/amplify-appsync-simulator/src/velocity/value-mapper/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class JavaMap {
}

keySet() {
return new JavaArray(Array.from(this.map.keys()), this.mapper);
return new JavaArray(Array.from(this.map.keys()).map(this.mapper as any), this.mapper);
}

put(key, value) {
Expand Down