Revert "Defer root stack creation to first amplify push"
#7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d28dd1c.
|
Should this PR be preferred over #7304? |
|
This pull request fixes 1 alert when merging c40f42a into d28dd1c - view on LGTM.com fixed alerts:
|
|
@cjihrig Yeah there are still some failures even with the changes in that other PR and I think it's going to take me more than a day to fix it all so I think it's best to revert until I can get all the tests passing |
cjihrig
approved these changes
May 11, 2021
|
👋 Hi, this pull request was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
github-actions
bot
added
the
referenced-in-release
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
…amplify#7174)" (aws-amplify#7306) This reverts commit d28dd1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7174
caused several e2e test failures: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/591/workflows/6d8ed2e9-bcc3-4a86-8e46-cfbb02ede9a1