Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove optional chaining in JS file #7287

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: remove optional chaining in JS file #7287

merged 1 commit into from
May 7, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 7, 2021

Description of changes

This syntax fails on older versions of Node.

Issue #, if available

Description of how you validated changes

Unit tests

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This syntax fails on older versions of Node.
@cjihrig cjihrig requested a review from a team as a code owner May 7, 2021 17:25
Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #7287 (d7d4247) into master (8775152) will decrease coverage by 4.06%.
The diff coverage is 46.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7287      +/-   ##
==========================================
- Coverage   56.43%   52.36%   -4.07%     
==========================================
  Files         445      497      +52     
  Lines       21859    25450    +3591     
  Branches     4373     4985     +612     
==========================================
+ Hits        12336    13328     +992     
- Misses       8745    11168    +2423     
- Partials      778      954     +176     
Impacted Files Coverage Δ
.../awscloudformation/utils/auth-defaults-appliers.ts 89.65% <0.00%> (ø)
...wscloudformation/utils/verification-bucket-name.ts 42.85% <0.00%> (ø)
packages/amplify-cli-core/src/deploymentState.ts 100.00% <ø> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.10% <ø> (ø)
...-cli/src/extensions/amplify-helpers/git-manager.ts 88.88% <ø> (+3.70%) ⬆️
.../amplify-frontend-ios/lib/amplify-config-helper.js 1.01% <ø> (ø)
...provider-awscloudformation/src/aws-utils/aws-s3.ts 9.32% <0.00%> (-0.77%) ⬇️
...ion/src/iterative-deployment/deployment-manager.ts 7.05% <0.00%> (ø)
...y-provider-awscloudformation/src/resourceParams.js 15.15% <ø> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212bf97...d7d4247. Read the comment docs.

@cjihrig cjihrig merged commit abb64f6 into aws-amplify:master May 7, 2021
@cjihrig cjihrig deleted the fixup branch May 7, 2021 18:03
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label May 14, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v4.51.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0.

cjihrig added a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
This syntax fails on older versions of Node.

Co-authored-by: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants