Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default values in DynamoDB VTLs #6277

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Dec 29, 2020

See aws/aws-appsync-community#59 for a related discussion.

Description of changes:

Translate default values defined in input models into default values when generating DynamoDB VTLs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ankon
Copy link
Contributor Author

ankon commented Dec 30, 2020

Before looking into fixing the CircleCI issues (I would need to figure out how to run mock_e2e_tests, and the test failure seems to be a problem in how the compiler is set up w.r.t. to the target platform), the first question is:

Do you think this is a viable approach to get default values into the templates?

@jhockett jhockett added the pending-review Pending review from core-team label Dec 31, 2020
@edwardfoyle edwardfoyle requested a review from akshbhu March 8, 2021 23:53
@lazpavel
Copy link
Contributor

closing in favor of: #8291

@lazpavel lazpavel closed this Oct 19, 2021
@ankon ankon deleted the pr/graphql-dynamodb-transformer-default-values branch December 30, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-review Pending review from core-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants