Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor amplify.json file handling #5282

Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix: refactor amplify.json file handling #5282

merged 1 commit into from
Sep 11, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Sep 9, 2020

Description of changes:

  • Together with feature flags amplify.json file introduced in the root folder of the project. It turned out to be a too common name as multiple Amplify projects are involved so to reduce the clutter the file has been renamed to cli.json and cli.{envName}.json accordingly and with this PR it gets created inside the amplify folder.
  • push/pull and env add support added to feature flags to cover more scenarios.
  • e2e tests covering the above operations also the removal of amplify.json files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #5282 into master will increase coverage by 0.12%.
The diff coverage is 86.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5282      +/-   ##
==========================================
+ Coverage   59.75%   59.87%   +0.12%     
==========================================
  Files         392      391       -1     
  Lines       17442    17465      +23     
  Branches     3465     3470       +5     
==========================================
+ Hits        10423    10458      +35     
+ Misses       6397     6384      -13     
- Partials      622      623       +1     
Impacted Files Coverage Δ
...amplify-cli-core/src/feature-flags/featureFlags.ts 80.48% <81.25%> (-1.24%) ⬇️
...-core/src/feature-flags/featureFlagFileProvider.ts 96.29% <100.00%> (-0.77%) ⬇️
.../amplify-cli-core/src/state-manager/pathManager.ts 70.42% <100.00%> (+25.64%) ⬆️
...amplify-cli-core/src/state-manager/stateManager.ts 50.00% <100.00%> (+9.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a324b2...e1cb479. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2020

This pull request introduces 3 alerts when merging b9d2fe1 into 59734ac - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@attilah attilah merged commit a6269f3 into aws-amplify:master Sep 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants