-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ES e2e deletePost and updatePost tests. Also making the tests stack names unique per execution. #5
Conversation
@@ -9,11 +9,14 @@ import AppSyncTransformer from 'graphql-appsync-transformer' | |||
import { CloudFormationClient } from '../CloudFormationClient' | |||
import { Output } from 'aws-sdk/clients/cloudformation' | |||
import { GraphQLClient } from '../GraphQLClient' | |||
import * as moment from 'moment'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we previously depend on moment? If not there needs to be an update to package.json devDependencies for all these packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added moment dependency for ES tests that got merged like a couple of days ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
feat: create-amplify app
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.