Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce ssl on s3 deployment bucket #13854

Closed

Conversation

awsluja
Copy link
Contributor

@awsluja awsluja commented Jul 17, 2024

Description of changes

Re-applying changes initially attempted in #10533

For more details on implementation, see guidance here: https://repost.aws/knowledge-center/s3-bucket-policy-for-config-rule

Issue #, if available

Description of how you validated changes

Tests updated to ensure ssl is enforced.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awsluja awsluja requested a review from a team as a code owner July 17, 2024 18:54
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the prerelease version strings

@@ -1,6 +1,6 @@
{
"name": "@aws-amplify/amplify-category-notifications",
"version": "2.26.21",
"version": "2.26.22-s3-bucket-ssl.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these versioning changes should be reverted. Main shouldn't have tagged release versions

@awsluja
Copy link
Contributor Author

awsluja commented Jul 18, 2024

closing in favor of #13857

@awsluja awsluja closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants