-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrates notifications category to support in app messaging channel notifications #11170
feat: migrates notifications category to support in app messaging channel notifications #11170
Conversation
* feat: in app messaging initial commit
… in-app-messaging
This pull request introduces 1 alert when merging 4f7f82b into 9ecc3f4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 45bd7bb into 9ecc3f4 - view on LGTM.com new alerts:
|
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-analytics/src/utils/pinpoint-helper.ts
Outdated
Show resolved
Hide resolved
/** | ||
* | ||
*/ | ||
export type PinpointApp = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future discussions.
we should tweak eslint to enforce docs only on types that we export outside of single package.
enforcing docs for internals isn't very productive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually missed it, it was added on save, but will leave it for now to not dismiss the approval, unless the recent changes broke something and will need tweaked
packages/amplify-category-analytics/src/migrations/in-app-messaging-migration.ts
Outdated
Show resolved
Hide resolved
…aging-migration.ts Co-authored-by: John Hockett <[email protected]>
…nnel notifications (#11170) * feat: migrates notifications category to support in app messaging channel notifications
Description of changes
Issue #11087
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.