fix: migration of Admin Queries on override command #9031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarkarachi
added a commit
that referenced
this pull request
Nov 23, 2021
* Api ext rebase 3 (#9001) * feat: extensibility for Amplify API (#8954) * feat: REST API extensibility (#8958) * fix: rebase fixes and bugs (#8960) * fix: rebase fixes and bugs * fix: service walkthrough call for appsync * fix: enable skeleton generation transformerFF is false (#8967) * feat: add min / max selection to prompter.pick (#8971) * fix: error handling, various bugs (#8976) * fix: tsconfig changes and renames (#8975) * fix: asana bug fixes * chore: allow js to false * fix: migration flow and cfn params when user pool groups are present, types (#8981) * fix: cfn parameters when user pool groups are present * fix: policy generation for user pool groups * fix: update types * test: fix project deletion even if meta validation fails * fix: rest iam policy roles array, bump ext helper types version (#8983) * fix: headless api migration (#8992) * fix: schema path inconsistencies, guest permissions, e2e * fix: api migration version e2es (#9000) Co-authored-by: John Hockett <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: jhockett <[email protected]> * fix: add missing ref call during rest stack generation, path casing (#9002) * fix: updates schema path on update api (#9005) * fix: api7 and api-migration tests (#9006) * fix: updates resource to resources and remove green ticks (#9007) * fix: overriding multiple userPoolGroups, ext helper type, lambda cfn (#9008) * fix: multiple userPoolGroups overwriting eachother * chore: update exported ext helper type * fix: lambda permissions not being generated * test: moved migration test and fixed the workflow (#9010) * test: moved migration test and fixed the workflow * test: remove jest settimeout Co-authored-by: AmmarKarachi <[email protected]> * fix: add missing property on path in cfn (#9011) * test: fixed integ test walkthrough (#9012) Co-authored-by: AmmarKarachi <[email protected]> * test: separate migration test helper from e2e (#9014) * fix: prediction migration test fix (#9015) * test: fix api_5.test.ts (#9017) * fix: single userpoolgroup name is iterated instead of being used (#9020) Co-authored-by: Sachin Panemangalore <[email protected]> * test: add missing option to e2e test (#9024) * fix: bucket parameters fetch logic (#9027) * fix: bucket parameters fetch logic * fix: address comments * fix: bucket parameters fetch logic (#9028) * fix: multiselect returns array when autoselecting (#9029) * fix: APIGW overrides package.json (#9032) * fix: package json dependencies * chore: new line at end of package.json * fix: migration of Admin Queries on override command (#9031) * fix: migration of Admin Queries on override command * fix: address feedback * feat: descoped http and functions override (#9035) * fix: address feedback (#9038) * fix: addressed comments (#9039) * fix: addressed comments * Update packages/amplify-provider-awscloudformation/src/download-api-models.ts Co-authored-by: Ammar <[email protected]> Co-authored-by: Ammar <[email protected]> Co-authored-by: akshbhu <[email protected]> Co-authored-by: John Hockett <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: jhockett <[email protected]> Co-authored-by: AmmarKarachi <[email protected]> Co-authored-by: Sachin Panemangalore <[email protected]> Co-authored-by: Sachin Panemangalore <[email protected]>
|
👋 Hi, this pull request was referenced in the v7.5.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.5.0. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Migration prompt was being asked twice, and not properly handled for Admin Queries when running
amplify override api.Added description to deployment match current behavior.
Issue #, if available
Description of how you validated changes
Manual testing,
apigw-ext-migration.test.tspasses, api category unit tests passChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.