-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use !ImportValue in custom resource YAML w/ v4.50.0 #7243
Comments
@kjones thanks for reporting the issue, just to give some background, the CLI runs through all the templates it discovers to look for S3 deployment keys as we need to pass those in as parameters in case the template references some automatically uploaded resources. I marked it as a bug as roundtripping YAML -> Object -> YAML should not have side effects. |
@kjones as a temporary workaround, the longform of the intrinsic function ( |
This should be resolved in v4.50.2, so I'll close this out. |
Sorry, #7245 has not been merged yet. Reopening and removing the pending-release label. |
👋 Hi, this issue was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
…ws-amplify#7245) * fix: aws-amplify#7243 yaml parsing should support all cfn functions
Before opening, please confirm:
How did you install the Amplify CLI?
npm install -g @aws-amplify/cli
If applicable, what version of Node.js are you using?
v14.15.0
Amplify CLI Version
4.50.0
What operating system are you using?
Mac Big Sur
Amplify Categories
Not applicable
Amplify Commands
push
Describe the bug
I have a custom resource that uses
!ImportValue
to reference an SNS topic from another CloudFormation stack. With 4.50.0 I get the following error when runningamplify push
I had no problems with this using 4.48.0 this morning. Then upgraded to 4.50.0 and immediately got the error. The custom resource template is:
Expected behavior
Don't choke 🤮 on yaml
!ImportValue
.Maybe also explain why the CLI even cares about the contents of my custom resource yaml.
Reproduction steps
See above
GraphQL schema(s)
N/A
Log output
Additional information
No response
The text was updated successfully, but these errors were encountered: