fix: publish returns with exitcode 1 #5413

akshbhu · 2020-09-25T21:58:03Z

Description of changes:

Added try/catch block when angular build fails and return with exitcode 1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov · 2020-09-25T22:11:32Z

Codecov Report

Merging #5413 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #5413    +/-   ##
========================================
  Coverage   59.12%   59.13%            
========================================
  Files         399      399            
  Lines       17974    17975     +1     
  Branches     3373     3560   +187     
========================================
+ Hits        10628    10629     +1     
+ Misses       6719     6698    -21     
- Partials      627      648    +21

Impacted Files	Coverage Δ
packages/amplify-cli-core/src/errors/index.ts	`100.00% <100.00%> (ø)`
packages/amplify-util-mock/src/api/api.ts	`0.00% <0.00%> (ø)`
packages/graphql-mapping-template/src/print.ts	`34.65% <0.00%> (ø)`
packages/amplify-util-mock/src/storage/storage.ts	`0.00% <0.00%> (ø)`
...ges/amplify-util-mock/src/CFNParser/stack/index.ts	`0.00% <0.00%> (ø)`
...es/amplify-util-mock/src/api/resolver-overrides.ts	`0.00% <0.00%> (ø)`
...es/graphql-transformer-core/src/stripDirectives.ts	`35.29% <0.00%> (ø)`
.../amplify-cli-core/src/state-manager/pathManager.ts	`70.42% <0.00%> (ø)`
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts	`0.00% <0.00%> (ø)`
...graphql-transformer-core/src/TransformerContext.ts	`26.10% <0.00%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88bee1...463e51c. Read the comment docs.

ammarkarachi · 2020-09-28T01:18:06Z

packages/amplify-cli/src/commands/publish.ts

+    }
+  } catch (e) {
+    context.print.error(`An error occurred during the publish operation`);
+    context.usageData.emitError(new FrontendBuildError());


Nice! @akshbhu

github-actions · 2021-09-29T01:44:52Z

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

fix: publish returns with exitcode 1

463e51c

akshbhu linked an issue Sep 25, 2020 that may be closed by this pull request

cli doesn't return exit code from publish (angular) #2809

Closed

akshbhu requested a review from UnleashedMind September 25, 2020 22:05

akshbhu requested a review from ammarkarachi September 28, 2020 18:28

ammarkarachi approved these changes Sep 28, 2020

View reviewed changes

akshbhu merged commit 2064830 into aws-amplify:master Sep 28, 2020

r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020

fix: publish returns with exitcode 1 (aws-amplify#5413)

09c7800

github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: publish returns with exitcode 1 #5413

fix: publish returns with exitcode 1 #5413

akshbhu commented Sep 25, 2020

codecov bot commented Sep 25, 2020

ammarkarachi Sep 28, 2020

github-actions bot commented Sep 29, 2021

fix: publish returns with exitcode 1 #5413

fix: publish returns with exitcode 1 #5413

Conversation

akshbhu commented Sep 25, 2020

codecov bot commented Sep 25, 2020

Codecov Report

ammarkarachi Sep 28, 2020

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2021