Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli doesn't return exit code from publish (angular) #2809

Closed
solshark opened this issue Nov 22, 2019 · 1 comment · Fixed by #5413
Closed

cli doesn't return exit code from publish (angular) #2809

solshark opened this issue Nov 22, 2019 · 1 comment · Fixed by #5413
Assignees
Labels
bug Something isn't working platform Issues tied to the general CLI platform

Comments

@solshark
Copy link

Describe the bug
amplify publish (for angular project) doesnt pass back exit code from ng build.
I was trying to setup CI/CD with gitlab and docker executioner. I used image with no angular cli installed for test purposes and spotted following issue:

> [email protected] build /builds/trinity/jumbo
> ng build

sh: ng: not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! [email protected] build: `ng build`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-11-22T10_59_12_859Z-debug.log
frontend build command exited with code 1
$ echo $?
0

Even if ng build failed amplify still returned exit code 0 which leads to CI jobs being marked as successfully completed.

Amplify CLI Version
3.17.0

Expected behavior
Return proper exit code.

Desktop (please complete the following information):

  • OS: Debian
  • Node 12-alpine
@ammarkarachi ammarkarachi added the pending-triage Issue is pending triage label Nov 22, 2019
@UnleashedMind UnleashedMind added bug Something isn't working platform Issues tied to the general CLI platform and removed pending-triage Issue is pending triage labels Feb 13, 2020
@akshbhu akshbhu linked a pull request Sep 25, 2020 that will close this issue
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working platform Issues tied to the general CLI platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants