fix: prevent infinite loop (#8540)

The loop in getResourcesToBeCreated() pushes items into the
array that it is iterating over. However, there was no check
for cycles, meaning that circular dependencies pushes resources
into the array until an out of memory error occurs. This commit
adds a check to prevent adding the same item to the array more
than once.

Co-authored-by: Ihrig <[email protected]>

packages/amplify-cli/src/extensions/amplify-helpers/resource-status-data.ts

@@ -212,7 +212,8 @@ export function getResourcesToBeCreated(amplifyMeta, currentAmplifyMeta, categor
           (!amplifyMeta[dependsOnCategory][dependsOnResourcename]?.lastPushTimeStamp ||
             !currentAmplifyMeta[dependsOnCategory] ||
             !currentAmplifyMeta[dependsOnCategory][dependsOnResourcename]) &&
-          amplifyMeta[dependsOnCategory][dependsOnResourcename].serviceType !== 'imported'
+          amplifyMeta[dependsOnCategory][dependsOnResourcename].serviceType !== 'imported' &&
+          !resources.includes(amplifyMeta[dependsOnCategory][dependsOnResourcename])
         ) {
           resources.push(amplifyMeta[dependsOnCategory][dependsOnResourcename]);
         }