Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add object existence validation option to get presigned url #2848

Merged
merged 18 commits into from
Jul 9, 2024

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Jun 12, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2404

Description of changes:
Update Storage getURL options to have a boolean flag to check for object existence. This provides feature parity with Amplify Swift

Doc PR: aws-amplify/docs#7736

How did you test these changes?

  • Manually tested getURL with new option enabled/disabled with and without object
  • Added unit tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 44.02%. Comparing base (0f61cc8) to head (05f1e84).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
+ Coverage   43.00%   44.02%   +1.01%     
==========================================
  Files         905      925      +20     
  Lines       29179    30293    +1114     
  Branches     4153     4305     +152     
==========================================
+ Hits        12549    13335     +786     
- Misses      15271    15531     +260     
- Partials     1359     1427      +68     

@phantumcode phantumcode requested a review from a team as a code owner June 13, 2024 15:16
Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few suggested changes.

tylerjroach
tylerjroach previously approved these changes Jun 28, 2024
lawmicha
lawmicha previously approved these changes Jul 3, 2024
tylerjroach
tylerjroach previously approved these changes Jul 3, 2024
@phantumcode phantumcode dismissed stale reviews from tylerjroach and lawmicha via 47d43d6 July 3, 2024 15:09
@phantumcode phantumcode merged commit 6dbb771 into main Jul 9, 2024
2 of 3 checks passed
@phantumcode phantumcode deleted the phantum/storage_getURL_update branch July 9, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants