-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add object existence validation option to get presigned url #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
==========================================
+ Coverage 43.00% 44.02% +1.01%
==========================================
Files 905 925 +20
Lines 29179 30293 +1114
Branches 4153 4305 +152
==========================================
+ Hits 12549 13335 +786
- Misses 15271 15531 +260
- Partials 1359 1427 +68 |
tylerjroach
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, a few suggested changes.
...rc/main/java/com/amplifyframework/storage/s3/request/AWSS3StorageGetPresignedUrlRequest.java
Outdated
Show resolved
Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/AWSS3StoragePlugin.java
Outdated
Show resolved
Hide resolved
...ain/java/com/amplifyframework/storage/s3/operation/AWSS3StorageGetPresignedUrlOperation.java
Show resolved
Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt
Show resolved
Hide resolved
...n/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathGetPresignedUrlOperation.kt
Show resolved
Hide resolved
lawmicha
reviewed
Jun 28, 2024
...t/java/com/amplifyframework/storage/s3/operation/AWSS3StorageGetPresignedUrlOperationTest.kt
Show resolved
Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt
Show resolved
Hide resolved
lawmicha
reviewed
Jun 28, 2024
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt
Show resolved
Hide resolved
tylerjroach
previously approved these changes
Jun 28, 2024
lawmicha
reviewed
Jun 28, 2024
...n/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathGetPresignedUrlOperation.kt
Outdated
Show resolved
Hide resolved
lawmicha
reviewed
Jul 2, 2024
...torage-s3/src/androidTest/java/com/amplifyframework/storage/s3/AWSS3StoragePathGetUrlTest.kt
Outdated
Show resolved
Hide resolved
lawmicha
reviewed
Jul 2, 2024
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt
Show resolved
Hide resolved
...torage-s3/src/androidTest/java/com/amplifyframework/storage/s3/AWSS3StoragePathGetUrlTest.kt
Show resolved
Hide resolved
lawmicha
previously approved these changes
Jul 3, 2024
tylerjroach
previously approved these changes
Jul 3, 2024
lawmicha
approved these changes
Jul 9, 2024
tylerjroach
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2404
Description of changes:
Update Storage getURL options to have a boolean flag to check for object existence. This provides feature parity with Amplify Swift
Doc PR: aws-amplify/docs#7736
How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.