fix(auth): Prevent credential continuation from returning multiple times. #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpanshu
reviewed
Aug 1, 2023
aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/CredentialStoreClientTest.kt
Show resolved
Hide resolved
mattcreaser
previously approved these changes
Aug 9, 2023
…ouble-continuation' into tjroach/prevent-loadCredential-double-continuation
sdhuka
previously approved these changes
Aug 9, 2023
sdhuka
approved these changes
Aug 9, 2023
mattcreaser
approved these changes
Aug 9, 2023
gpanshu
approved these changes
Aug 9, 2023
tylerjroach
deleted the
tjroach/prevent-loadCredential-double-continuation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2368
Description of changes:
This PR should resolve a race condition caused from the referenced issue.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.