fix(datastore): Flutter: fail to serialize list of custom type values #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
div5yesh
previously approved these changes
Jun 1, 2023
mattcreaser
approved these changes
Jun 1, 2023
mattcreaser
previously approved these changes
Jun 1, 2023
HuiSF
force-pushed
the
hui/fix/datastore/serialized-custom-type-cast
branch
from
13794c2
to
188d157
Compare
mattcreaser
approved these changes
Jun 8, 2023
tylerjroach
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
A custom type field may contain a single custom type, or a list custom type, the original code change fails to handle the latter. This PR fixes this issue.
This change is isolated to Flutter use cases only.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.