Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): Add recoverability improvements #2201

Merged
merged 21 commits into from
Feb 1, 2023
Merged

feat(datastore): Add recoverability improvements #2201

merged 21 commits into from
Feb 1, 2023

Commits on Jan 31, 2023

  1. make SyncProcessor retry enabled always

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9a4abcc View commit details
    Browse the repository at this point in the history

  2. Rename jitteredDelaySec to jitteredDelayMillis and make it return mil… 

    …liseconds.

Rename jitterFactor to jitterMs to better convey that it is a random amount of milliseconds added on top of the calculated delay.

Remove maxExponent since the jitteredDelay method already caps to a max defined by maxDelayMs.

Make tests use Durations in assertions to express that we are working with time units.

Fix code analysis checks
    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8b724ea View commit details
    Browse the repository at this point in the history

  3. Remove max attempts from jitteredDelayMillis since it already caps to… 

    … a max with maxDelayMs.

Log more information about the state of the RetryHandler.

Make the RetryHandler easier to test by making it accept an scheduler for the timer.

Fix checkstyle issues.
    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    41138f1 View commit details
    Browse the repository at this point in the history

  4. Make the sync processor stop retries on irrecoverable errors

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    bba6501 View commit details
    Browse the repository at this point in the history

  5. - Log websocket messages (verbose level) 

    - Make MutationProcessor retry any non-GraphQLResponseException
- Remove isSyncRetryEnabled from config
    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7ba8ec6 View commit details
    Browse the repository at this point in the history

  6. Add additional logging

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    84b4d75 View commit details
    Browse the repository at this point in the history

  7. Fix checkstyle errors

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0f75e7f View commit details
    Browse the repository at this point in the history

  8. Make RetryHandler not retry beyond maxDelay

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    61c030b View commit details
    Browse the repository at this point in the history

  9. Fix unit test

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9170f03 View commit details
    Browse the repository at this point in the history

  10. Handle non-json data and other errors

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    105e322 View commit details
    Browse the repository at this point in the history

  11. Fix MutationProcessor test

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    468e70d View commit details
    Browse the repository at this point in the history

  12. Pass a dataStoreConfiguration instead of a ConflictResolver to the Mu… 

    …tationProcessor
    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9f0ea77 View commit details
    Browse the repository at this point in the history

  13. Remove unused constant

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d209517 View commit details
    Browse the repository at this point in the history

  14. Prevent mutation processor halting on errors.

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b32e222 View commit details
    Browse the repository at this point in the history

  15. Log incoming and outgoing websocket messages

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    91e1a31 View commit details
    Browse the repository at this point in the history

  16. Add test for errorHandler on MutationProcessor

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4007b77 View commit details
    Browse the repository at this point in the history

  17. Test that non-json responses are converted to ApiException

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    48fdf1e View commit details
    Browse the repository at this point in the history

  18. Address review comments

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    92ddbab View commit details
    Browse the repository at this point in the history

  19. Revert isSyncRetryEnabled and mark it as deprecated

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e610f94 View commit details
    Browse the repository at this point in the history

  20. Make GsonGraphQLResponseFactory.buildResponse throw on empty string

    @manueliglesias
    manueliglesias committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    6dc738f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Merge branch 'main' into manuelig/recoverability

    @mattcreaser
    mattcreaser authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    002cffd View commit details
    Browse the repository at this point in the history