fix(datastore): Propagate error if mutation process failed to drain outbox #1794 #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @shantanu-saha-europcar, it looks like #1794 was resolved in #2201 and release in 2.2.0. I'll close this PR for now, please let me know if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1794
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Disable the internet (not the network)
Do a mutation, wait for mutation exception
The sync stop process should be triggered
Added Unit Tests
Added Integration Tests
Documentation update required?
closes #1794
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.