Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Fix for flutter backtick #1866

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Conversation

poojamat
Copy link
Contributor

@poojamat poojamat commented Jul 30, 2022

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Flutter fix for back ticks in sql query where predicate.How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Tested on frontend (Add Screenshots)
  • Successful logs (Attach them to the PR)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@poojamat poojamat requested review from a team as code owners July 30, 2022 22:54
…rage/sqlite/SQLiteCommandFactory.java

Co-authored-by: Hui Zhao <[email protected]>
HuiSF
HuiSF previously approved these changes Aug 1, 2022
HuiSF
HuiSF previously approved these changes Aug 1, 2022
Removing extra line.
Copy link
Member

@sktimalsina sktimalsina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title of PR as recommended so that it shows up correctly in changelist as mentioned in the checklist in PR template:
https://github.com/aws-amplify/amplify-android/blob/main/CONTRIBUTING.md#pull-request-guidelines
fix(api):

Copy link
Contributor

@eeatonaws eeatonaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests we can add for this fix?

@poojamat poojamat changed the title Fix for flutter backtick fix(datastore): Fix for flutter backtick Aug 11, 2022
@poojamat poojamat merged commit 2db6f0d into main Aug 11, 2022
@poojamat poojamat deleted the flutter-fix-backticks branch August 11, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants