fix(aws-api-appsync): update getModelFields for flutter support #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojamat
approved these changes
Dec 20, 2021
poojamat
reviewed
Dec 20, 2021
@jpignata doesn't agree |
…x/1610-flutter-observe-nested-data
@poojamat I added a unit test for the new behavior for SerializedModel in aws-api-appsync. The unit tests seem to be failing in CI, although they are passing locally. I will look into that and update if needed. |
eeatonaws
reviewed
Jan 5, 2022
| @@ -0,0 +1,59 @@ | |||
| /* | |||
| * Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Should the copyright year be 2022?
Jordan-Nelson
commented
Jan 5, 2022
aws-api-appsync/src/test/java/com/amplifyframework/api/aws/JustIDGraphQLRequestOptions.java
Outdated
Show resolved
Hide resolved
…tIDGraphQLRequestOptions.java
eeatonaws
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1610
Description of changes:
getModelFieldsmethod for flutter support to match the version used for native apps. The changes are identical to the changes in https://github.com/aws-amplify/amplify-android/pull/1585/files, but are applied to the version ofgetModelFieldsthat is used for flutter supportBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.