feat(datastore): Add non-model type support for amplify-flutter #1459
Conversation
| public static synchronized SchemaRegistry instance() { | ||
| if (SchemaRegistry.instance == null) { | ||
| SchemaRegistry.instance = new SchemaRegistry(); | ||
| } | ||
|
|
||
| return SchemaRegistry.instance; |
There was a problem hiding this comment.
From this use case of SchemaRegistry, it looks like SchemaRegistry should be a singleton. The original code didn't work and didn't break either as the original logic wasn't really depending on retrieving a valid model schema.
| @@ -28,7 +28,7 @@ | |||
| import com.amplifyframework.core.model.ModelAssociation; | |||
| import com.amplifyframework.core.model.ModelField; | |||
| import com.amplifyframework.core.model.ModelSchema; | |||
| import com.amplifyframework.core.model.ModelSchemaRegistry; | |||
There was a problem hiding this comment.
What was the rationale behind renaming this class?
There was a problem hiding this comment.
Thanks for asking :)
ModelSchemaRegistry not holds CustomTypeSchema as well, the original name was leading by Model which could be confusing, so updated to just SchemaRegistry.
| * @param modelSchema schema for the Model object | ||
| * @param <T> type of the Model object. | ||
| * @param <T> type of the Model object. |
There was a problem hiding this comment.
nit: some of the formatting looks like it needs to be corrected
There was a problem hiding this comment.
This formatting is automatically added by the IDE I think, which align parameter description block with each other for readability.
Issue #, if available: amplify-flutter #260
Description of changes:
ModelSchemaRegistrysupport registeringCustomTypeschemasSerializedModelnestingSerializedCustomTypeSerializedCustomTypefor amplify-flutterTasks
ModelSchemaRegistrytoSchemaRegistryCustomTypeSchema,SerializedCustomTypeand related classesSerializedCustomTypewith amplify-flutter use casesaws-api-appsyncaws-datastorecoreBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.